fix: use backticks for inline snaps when appropriate #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Dec 24, 2025
snaps/matchInlineSnapshot.go
Outdated
Comment on lines
230
to
234
| v := fmt.Sprintf("`%s`", s) | ||
| if isSingleline(s) { | ||
| // Use double quotes if the string can be safely represented as a Go string literal (no unescaped newlines, backquotes, etc.) | ||
| if !hasEscapable(s) { | ||
| v = fmt.Sprintf("%q", s) | ||
| } |
There was a problem hiding this comment.
Any reason to do not use strconv.CanQuote ?
Owner
Author
There was a problem hiding this comment.
Do you mean the CanBackQuote ? For the examples I am checking with it's always returning true resulting to this.
t.Run("should make an inline snapshot", func(t *testing.T) {
u := struct {
User string
Age int
}{
User: "mock-name",
Age: 30,
}
snaps.MatchInlineSnapshot(
t,
u,
- snaps.Inline("struct { User string; Age int }{User:\"mock-name\", Age:30}"),
+ snaps.Inline(`struct { User string; Age int }{User:"mock-name", Age:30}`),
)
})
gkampitakis
force-pushed
the
gkampitakis/inline_snaps_backticks
branch
from
658ec76 to
a4c3f2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.