fix: only update snapshots when actually allowed #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've opened #137 to address the linting failure |
G-Rath
commented
Sep 16, 2025
gkampitakis
approved these changes
Sep 17, 2025
Owner
gkampitakis
left a comment
gkampitakis
left a comment
There was a problem hiding this comment.
Thank you for taking care of this and the time spent to properly document it and on the issue to explain to me what's the problem 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the cleaning logic to not do anything if updating is not allowed, in which case we instead mark if the snapshot needs updating (aka if it's dirty).
While the actual fix is just a few lines, I've also renamed a few variables and added some comments to make it easier (imo) to understand the logic - I'm happy to change or revert any of those if desired 🙂
Closes #134
Resolves #133