Skip to content

Fix AppVeyor - add Scripts to path for current Python #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

techtonik
Copy link
Contributor

Tests are failing, because only Python 2.7 is present in PATH

Tests are failing, because only Python 2.7 is present in PATH
@techtonik
Copy link
Contributor Author

At least Python 2 is now fully covered, but it looks like pbs is not fully compatible with Python 3.

@techtonik
Copy link
Contributor Author

I restored pbs project history https://github.com/techtonik/pbs but that's it for now. Need patches.

@spderosso spderosso merged commit f14e52d into gitless-vcs:master Jul 11, 2017
@spderosso
Copy link
Member

Thank you for doing this.

I haven't looked into the pbs code so I am not sure how hard it'd be to make it compatible with Python 3 but it might not be worth the effort. We could say that on Windows we support Python 2 only (and update the appveyor file accordingly).

@techtonik techtonik deleted the patch-1 branch July 12, 2017 09:34
@techtonik
Copy link
Contributor Author

Another possibility is to switch to plumbum, which seems to be crossplatform, but syntax needs to be investigated. tomerfiliba/plumbum#332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants