-
Notifications
You must be signed in to change notification settings - Fork 151
Storage testing #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Storage testing #303
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a9ab7d2
Configure benchmarks LFS
hendrikvanantwerpen bcfa9ed
Use LFS for performance benchmark
hendrikvanantwerpen 3114ca7
End-to-end CLI test
hendrikvanantwerpen 5f12b91
Fix workflow
hendrikvanantwerpen 98d46ea
Cancel workflow runs on new push
hendrikvanantwerpen 3890d7a
Fix typo
hendrikvanantwerpen f9907a1
Do not serialize jobs for quicker results
hendrikvanantwerpen b6a059b
Fix path
hendrikvanantwerpen a7e8b22
Keep using checkout for base branch
hendrikvanantwerpen 06f8c28
Use curated data sets for CI
hendrikvanantwerpen 46bca31
Fix CLI test
hendrikvanantwerpen 8d37445
Cleanup perf workflow
hendrikvanantwerpen 342d987
force-perf-test
hendrikvanantwerpen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
data/*.tar.gz filter=lfs diff=lfs merge=lfs -text | ||
data/*.tgz filter=lfs diff=lfs merge=lfs -text | ||
data/*.zip filter=lfs diff=lfs merge=lfs -text | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Performance Benchmark | ||
|
||
A set of files, taken from the TypeScript compiler v4.9.5, of different sizes: | ||
|
||
``` | ||
15 text files. | ||
15 unique files. | ||
0 files ignored. | ||
|
||
github.com/AlDanial/cloc v 1.96 T=0.12 s (121.5 files/s, 250225.1 lines/s) | ||
--------------------------------------------------------------------------------------------- | ||
File blank comment code | ||
--------------------------------------------------------------------------------------------- | ||
typescript_benchmark/types.ts 1085 1548 6642 | ||
typescript_benchmark/nodeFactory.ts 598 758 5544 | ||
typescript_benchmark/es2015.ts 477 1082 2861 | ||
typescript_benchmark/generators.ts 301 903 1985 | ||
typescript_benchmark/module.ts 173 394 1437 | ||
typescript_benchmark/system.ts 204 546 1195 | ||
typescript_benchmark/resolutionCache.ts 112 101 920 | ||
typescript_benchmark/sourcemap.ts 99 47 614 | ||
typescript_benchmark/utilities.ts 64 92 371 | ||
typescript_benchmark/emitNode.ts 35 87 172 | ||
typescript_benchmark/es5.ts 10 40 72 | ||
typescript_benchmark/node.ts 14 4 66 | ||
typescript_benchmark/builderPublic.ts 8 117 56 | ||
typescript_benchmark/es2019.ts 4 1 33 | ||
typescript_benchmark/builderStatePublic.ts 1 0 13 | ||
--------------------------------------------------------------------------------------------- | ||
SUM: 3185 5720 21981 | ||
--------------------------------------------------------------------------------------------- | ||
``` |
Git LFS file not shown
Git LFS file not shown
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not clear on when LFS is required vs not required in local dev. Does this require interacting with LFS for local dev in anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question 🤔 I think when you change things matching the patterns, you'll have to. But they're currently only used in CI, so in most cases I don't think so. But I'll try this out and otherwise open a follow-up PR updating docs around this. (An external contributor wants to address the serialization bug, so merging this will help set them up easier.)