Skip to content

Updates to language project structure #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 12, 2023
Merged

Updates to language project structure #245

merged 12 commits into from
May 12, 2023

Conversation

hendrikvanantwerpen
Copy link
Collaborator

@hendrikvanantwerpen hendrikvanantwerpen commented Mar 29, 2023

This PR introduces a couple of changes related to project setups.

  • Some projects would use an on-by-default test feature. This is replaced with with dev-dependencies. This ensures that tests are run without having to specify a feature, but without always pulling in those dependencies for crate users.

  • The tree-sitter-stack-graphs init command now supports a --internal flag that generates a project with the right configuration to line inside this repository. For example, they include the path in dependencies, and use the right license header.

  • A new CI job tests that new projects generated by tree-sitter-stack-graphs init compile without errors.

I ended up upgrading clap to version 4, so some of the changes are due to that.

@hendrikvanantwerpen hendrikvanantwerpen changed the title Use dev-dependencies instead of a default feature Updates to project structure May 11, 2023
@hendrikvanantwerpen hendrikvanantwerpen changed the title Updates to project structure Updates to language project structure May 11, 2023
Copy link
Member

@rewinfrey rewinfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the CI test for the init CLI command, this looks good to me! 👍

@hendrikvanantwerpen hendrikvanantwerpen merged commit 1df3ad8 into main May 12, 2023
@hendrikvanantwerpen hendrikvanantwerpen deleted the dev-deps branch May 12, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants