-
Notifications
You must be signed in to change notification settings - Fork 62.4k
Updating the documentation for Configuring SAML & SCIM in OKTA to include steps for adding the GHEC - Org app integration. #22476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…able GitHub OAuth Integration.
…pp integration in OKTA.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@stacycarter Hey! I put this docs contribution together to try to make these docs a bit clearer when setting up SAML for an Org in OKTA. Would you mind reviewing the changes I made? You can see them here: https://docs-22476-d70dcc.preview.ghdocs.com/en/enterprise-cloud@latest/organizations/managing-saml-single-sign-on-for-your-organization/configuring-saml-single-sign-on-and-scim-using-okta |
👋 @adamrr724 Thanks for submitting a PR! I edited your post slightly to link it to your issue ✨ I'll get this triaged for review! ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adamrr724! I'm going to apply some suggestions to better follow our style guide and content models. Then, I need you to save your new images in the repository, please... I've updated the image references to include the directory and file names you should use. After you've done that, let me know, and I'll do another review. 😊
...-single-sign-on-for-your-organization/configuring-saml-single-sign-on-and-scim-using-okta.md
Outdated
Show resolved
Hide resolved
...-single-sign-on-for-your-organization/configuring-saml-single-sign-on-and-scim-using-okta.md
Outdated
Show resolved
Hide resolved
Part of the reason these docs needed to be updated was to make these titles/steps more specific. Oauth App Integration in OKTA ≠ GitHub Oauth App, and specifying that this is being set up for SAML -- specifically for a GHEC organization (and not for an enterprise) -- is very important in providing clarity.
Adding my description from the most recent commit to add context as to why those titles should remain more specific: Part of the reason these docs needed to be updated was to make these titles/steps more specific. Oauth App Integration in OKTA ≠ GitHub Oauth App, and specifying that this is being set up for SAML -- specifically for a GHEC organization (and not for an enterprise) -- is very important in providing clarity. |
Thanks for that clarification!
I agree, but that is true for the entire article, so we should be establishing that in the article title and overall conceptual content for the whole article, not individual section headings. I agree we could do a better job of that (probably because SAML only existed at the organization level when this article was originally created/named), but that's beyond the scope of this update. Could you please open an issue in |
...-single-sign-on-for-your-organization/configuring-saml-single-sign-on-and-scim-using-okta.md
Outdated
Show resolved
Hide resolved
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am with you
Why:
Closes : #22475
What's being changed (if available, include any code snippets, screenshots, or gifs):
I have added steps to the "Configuring SAML single sign-on and SCIM using Okta" page to include the steps for adding the app integration necessary to set up SAML on OKTA using GitHub. This includes a reusable widget for searching for and adding the correct app integration and includes one screenshot.
Check off the following: