Skip to content

fix: format of octokit.js link #22446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2022
Merged

fix: format of octokit.js link #22446

merged 4 commits into from
Dec 5, 2022

Conversation

zacanger
Copy link
Contributor

@zacanger zacanger commented Dec 4, 2022

This just happened to bug me when I was browsing the docs — changes to be consistent with the other official library links.

Why:

Closes #22445

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fixes format of octokit.js link. This just happened to bug me when I was browsing the docs — changes to be consistent with the other official library links.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

This just happened to bug me when I was browsing the docs — changes to be consistent with the other official library links.
@welcome
Copy link

welcome bot commented Dec 4, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
rest/overview/libraries.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@zacanger Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review rest Content related to rest - overview. and removed triage Do not begin working on this issue until triaged by the team labels Dec 5, 2022
Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@cmwilson21
Copy link
Contributor

Thanks for this update! I'll get it merged down once all the tests have passed ✅

@cmwilson21 cmwilson21 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Dec 5, 2022
@cmwilson21 cmwilson21 enabled auto-merge December 5, 2022 17:10
@cmwilson21 cmwilson21 merged commit 0ce1200 into github:main Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge rest Content related to rest - overview.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent format of official library links
2 participants