-
Notifications
You must be signed in to change notification settings - Fork 62.4k
Add needs:
syntax example using always()
condition
#1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for the PR, I guess, if you seeking any change or question about anything in the docs, you can use discussion or create a new issue instead to communicate about it.
I can update the PR if I get confirmation that using
is the canonical way to run job3 after job1 and job2 and whether or not job1 and job2 are successful or not |
This comment has been minimized.
This comment has been minimized.
Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review! |
@janiceilene done :) |
Thanks so much @remyleone! I'll get this triaged for review 🌟 |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
@remyleone Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨ |
(Just for information: I updated this PR from |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Hi @remyleone, thanks a lot for this suggestion! 🙇♂️ Another example for this would definitely be helpful! I've made some edits to your PR to fix failing tests as well as make it more consistent with our style and other examples. Because I've made some significant changes myself, I'll get another writer on the team to review this before we merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lucascosti! Added some non-blocking personal preference suggestions.
content/actions/reference/workflow-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
@@ -270,6 +270,20 @@ The jobs in this example run sequentially: | |||
2. `job2` | |||
3. `job3` | |||
|
|||
#### Example not requiring dependent jobs to be successful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll raise a docs issue for all the titles in this guide, so that we can move them to an "Example: verb
" convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #2063 👍
needs:
syntax example using always()
condition
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
* [TimescaleDB] Continue moving frontmatter Co-authored-by: Lana Brindley <[email protected]>
Why:
It was confusing for me to understand how the different dependencies between jobs are working. Adding an example about conditional execution of jobs would have helped me understand more quickly how to solve a problem I had using GitHub action.
What's being changed:
I've added an example about how to mix conditional and dependencies between jobs to ensure that a job always gets executed regardless of the results of jobs it depends on.
This is particularly useful when you have a "cleanup/sweeper" kind of job that you want to execute regardless or whether or not previous jobs worked.
Check off the following: