Skip to content

JavaScript: Update to TypeScript 4.8 #10184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 29, 2022
Merged

JavaScript: Update to TypeScript 4.8 #10184

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7367ca
update to TypeScript 4.8RC
erik-krogh Aug 20, 2022
97ffd2d
add change-note
erik-krogh Aug 25, 2022
e0ff273
bump extractor version
erik-krogh Aug 25, 2022
50734c7
bump the TypeScript version in the list of supported languages
erik-krogh Aug 25, 2022
6aca9b9
fix support for illegal decorators in the TypeScript extractor
erik-krogh Aug 29, 2022
56292ca
don't modify the TypeScript nodes, instead forward illegalDecorators …
erik-krogh Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions javascript/extractor/lib/typescript/src/ast_extractor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,12 @@ export function augmentAst(ast: AugmentedSourceFile, code: string, project: Proj
}
}

// This PR: https://github.com/microsoft/TypeScript/pull/50343/ changed how illegal decorators are stored, this hack reverts it.
// Those decorator uses are syntax errors, but people use them anyway.
if ((node as any).illegalDecorators) {
(node as any).decorators = (node as any).illegalDecorators;
}

if (typeChecker != null && insideConditionalTypes === 0) {
if (isTypedNode(node)) {
let contextualType = isContextuallyTypedNode(node)
Expand Down