Skip to content

Push refs in smaller batches. #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Push refs in smaller batches. #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 37 additions & 14 deletions internal/push/push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,18 @@ func (pushService *pushService) createRepository() (*github.Repository, error) {
return repository, nil
}

func splitLargeRefSpecs(refSpecs []config.RefSpec) [][]config.RefSpec {
splitRefSpecs := [][]config.RefSpec{}
for i := 0; i < len(refSpecs); i += 25 {
end := i + 100
if end > len(refSpecs) {
end = len(refSpecs)
}
splitRefSpecs = append(splitRefSpecs, refSpecs[i:end])
}
return splitRefSpecs
}

func (pushService *pushService) pushGit(repository *github.Repository, initialPush bool) error {
remoteURL := pushService.gitURL
if remoteURL == "" {
Expand Down Expand Up @@ -210,9 +222,10 @@ func (pushService *pushService) pushGit(repository *github.Repository, initialPu
deleteRefSpecs = append(deleteRefSpecs, config.RefSpec(":"+remoteReference.Name().String()))
}
}
refSpecBatches = append(refSpecBatches, deleteRefSpecs)
refSpecBatches = append(refSpecBatches, splitLargeRefSpecs(deleteRefSpecs)...)

defaultBranchRefSpec := "+refs/heads/main:refs/heads/main"
defaultBranchRef := "refs/heads/main"
defaultBranchRefSpec := "+" + defaultBranchRef + ":" + defaultBranchRef
if initialPush {
releasePathStats, err := ioutil.ReadDir(pushService.cacheDirectory.ReleasesPath())
if err != nil {
Expand All @@ -227,20 +240,30 @@ func (pushService *pushService) pushGit(repository *github.Repository, initialPu
}
initialRefSpecs = append(initialRefSpecs, config.RefSpec("+"+tagReferenceName.String()+":"+tagReferenceName.String()))
}
refSpecBatches = append(refSpecBatches, initialRefSpecs)
refSpecBatches = append(refSpecBatches, splitLargeRefSpecs(initialRefSpecs)...)
} else {
// We've got to push the default branch on its own, so that it will be made the default branch if the repository has just been created. We then push everything else afterwards.
refSpecBatches = append(refSpecBatches,
[]config.RefSpec{
config.RefSpec(defaultBranchRefSpec),
},
[]config.RefSpec{
config.RefSpec("+refs/*:refs/*"),
},
)
nonDefaultRefSpecs := []config.RefSpec{}
localReferences, err := gitRepository.References()
if err != nil {
return errors.Wrap(err, "Error listing local references.")
}
localReferences.ForEach(func(ref *plumbing.Reference) error {
if ref.Name().String() != defaultBranchRef && strings.HasPrefix(ref.Name().String(), "refs/") {
nonDefaultRefSpecs = append(nonDefaultRefSpecs, config.RefSpec("+"+ref.Name().String()+":"+ref.Name().String()))
}
return nil
})
refSpecBatches = append(refSpecBatches, splitLargeRefSpecs(nonDefaultRefSpecs)...)
}
for _, refSpecs := range refSpecBatches {
if len(refSpecs) != 0 {
log.Debugf("Pushing refspecs %s.", refSpecs)
err = remote.PushContext(pushService.ctx, &git.PushOptions{
RefSpecs: refSpecs,
Auth: credentials,
Expand Down Expand Up @@ -393,17 +416,17 @@ func (pushService *pushService) pushReleases() error {
existingAssets = append(existingAssets, assets...)
}

assetsPath := pushService.cacheDirectory.AssetsPath(releaseName)
assetPathStats, err := ioutil.ReadDir(assetsPath)
//assetsPath := pushService.cacheDirectory.AssetsPath(releaseName)
//assetPathStats, err := ioutil.ReadDir(assetsPath)
if err != nil {
return errors.Wrap(err, "Error reading release assets.")
}
for _, assetPathStat := range assetPathStats {
err := pushService.createOrUpdateReleaseAsset(release, existingAssets, assetPathStat)
if err != nil {
return err
}
}
// for _, assetPathStat := range assetPathStats {
// err := pushService.createOrUpdateReleaseAsset(release, existingAssets, assetPathStat)
// if err != nil {
// return err
// }
// }
}

return nil
Expand Down
Loading