-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add support for MiniScript #7384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
67a120c to
8ead033
Compare
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
samples/MiniScript/superstartrek.ms and samples/MiniScript/textAdventure.ms are way too big for our needs - if the diff suppresses the content, it's too big. Please remove them.
Please also update the search query in the PR template to use your heuristics so we can assess popularity and your heuristics.
Done. Both large MiniScript samples have been removed.
I've updated the query to include some of the keywords and special variables. While it might not catch every single MiniScript related file, it should cover the majority. |
You can use regex in GitHub's search too. |
|
I've reduced the complexity of the heuristics pattern significantly now. Mainly relying on the end block keyword. Additionally I added two more extensions since those should also be relevant to MiniScript. |
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
|
Commenting mainly to get notifications on this issue (I can't find a Subscribe or Watch button). But just to be sure I understand: With the |
Essentially, yes. More deets in #5756 |
|
Is it possible for this pr to get accepted before the 2000 files mark, or is that a hard requirement? |
|
Hard requirement. If we make an exception for one there's no point having the restriction and we'd have no choice but to accept every submission, even for hobby languages that no one uses. |
From the MiniScript manual:
More informations about MiniScript can be found here:
Following changes are performed in this PR:
.msChecklist:
#494247