Skip to content

Conversation

@ayecue
Copy link

@ayecue ayecue commented May 17, 2025

From the MiniScript manual:

MiniScript is a modern scripting language designed to be clean, simple, and easy to learn. It
was designed from the ground up by borrowing only the best ideas from other languages
such as Python, Lua, Basic, and C#. If you know pretty much any other programming
language, you’ll pick up MiniScript almost immediately.

And if you’ve never written a line of code in your life, don’t panic! MiniScript is the
friendliest and most fun way to get started. It’s much easier than you probably expect.

Important: MiniScript is designed as an embedded programming language. That means
you will usually use it inside some other program, such as a video game. You should find
another document that describes how to access and use MiniScript within that other
program. This document only describes the MiniScript language itself, and the intrinsic
functions that are common to most MiniScript applications.

More informations about MiniScript can be found here:

Following changes are performed in this PR:

Checklist:

@ayecue ayecue requested a review from a team as a code owner May 17, 2025 14:44
@ayecue ayecue force-pushed the main branch 2 times, most recently from 67a120c to 8ead033 Compare May 18, 2025 12:34
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples/MiniScript/superstartrek.ms and samples/MiniScript/textAdventure.ms are way too big for our needs - if the diff suppresses the content, it's too big. Please remove them.

Please also update the search query in the PR template to use your heuristics so we can assess popularity and your heuristics.

@ayecue
Copy link
Author

ayecue commented May 19, 2025

samples/MiniScript/superstartrek.ms and samples/MiniScript/textAdventure.ms are way too big for our needs - if the diff suppresses the content, it's too big. Please remove them.

Done. Both large MiniScript samples have been removed.

Please also update the search query in the PR template to use your heuristics so we can assess popularity and your heuristics.

I've updated the query to include some of the keywords and special variables. While it might not catch every single MiniScript related file, it should cover the majority.

@lildude
Copy link
Member

lildude commented May 19, 2025

I've updated the query to include some of the keywords and special variables. While it might not catch every single MiniScript related file, it should cover the majority.

You can use regex in GitHub's search too.

@ayecue
Copy link
Author

ayecue commented May 21, 2025

I've reduced the complexity of the heuristics pattern significantly now. Mainly relying on the end block keyword. Additionally I added two more extensions since those should also be relevant to MiniScript.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@JoeStrout
Copy link

Commenting mainly to get notifications on this issue (I can't find a Subscribe or Watch button). But just to be sure I understand:

With the Pending Popularity tag, this issue is on hold until we cross some threshold? Is it for this search to return 2000 files, or something else?

@lildude
Copy link
Member

lildude commented Jun 2, 2025

With the Pending Popularity tag, this issue is on hold until we cross some threshold? Is it for this search to return 2000 files, or something else?

Essentially, yes. More deets in #5756

@EntitySeaker
Copy link

Is it possible for this pr to get accepted before the 2000 files mark, or is that a hard requirement?

@lildude
Copy link
Member

lildude commented Jun 5, 2025

Hard requirement. If we make an exception for one there's no point having the restriction and we'd have no choice but to accept every submission, even for hobby languages that no one uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants