Skip to content

Fixed heuristic for the OMNeT++ MSG language #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2025
Merged

Fixed heuristic for the OMNeT++ MSG language #7157

merged 2 commits into from
Jan 8, 2025

Conversation

@adamgeorge309
Copy link
Contributor

@adamgeorge309 adamgeorge309 commented Dec 13, 2024

Extended the heuristic because the previous one didn't find some smaller msg files

Checklist:

  • I am fixing a misclassified language
    • I have included a change to the heuristics to distinguish my language from others using the same extension.

@adamgeorge309 adamgeorge309 requested a review from a team as a code owner December 13, 2024 13:59
@torokati44
Copy link

torokati44 commented Dec 18, 2024

See for example: https://github.com/omnetpp/omnetpp/blob/39b4df520eee4a10e400409cd0b3d99a7d790960/samples/tictoc/tictoc13.msg

lildude
lildude reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Jan 8, 2025
Merged via the queue into github-linguist:main with commit 13aa301 Jan 8, 2025
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lildude lildude lildude approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamgeorge309 @torokati44 @lildude