Skip to content

compute_stats: raise exception if tree.count_recursive > MAX_TREE_SIZE #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

compute_stats: raise exception if tree.count_recursive > MAX_TREE_SIZE #4038

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95548c7
compute_stats: raise exception if tree.count_recursive > MAX_TREE_SIZE
Feb 16, 2018
3b6a80a
Merge branch 'master' into adelcast/add_exception_on_error
lildude Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/linguist/repository.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def current_tree
MAX_TREE_SIZE = 100_000

def compute_stats(old_commit_oid, cache = nil)
return {} if current_tree.count_recursive(MAX_TREE_SIZE) >= MAX_TREE_SIZE
raise "Your repo tree size exceeds the MAX_LIMIT" if current_tree.count_recursive(MAX_TREE_SIZE) >= MAX_TREE_SIZE
Copy link
Collaborator

@Alhadis Alhadis Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword this to be:

raise "Repository tree size exceeds MAX_LIMIT (#{MAX_LIMIT})"

Also, did you mean MAX_TREE_SIZE instead of MAX_LIMIT? I don't see the latter being used here.


old_tree = old_commit_oid && Rugged::Commit.lookup(repository, old_commit_oid).tree
read_index
Expand Down