Skip to content

Conversation

@kivikakk
Copy link
Contributor

Even better than #3899, a straight-up fix.

  • Ensure we handle input returning 0 as EOF so as to not trigger an extra YY_INPUT call into nothing.
  • Stop using all trailing context; it's equivalent to REJECT and results in an unresizeable buffer.
  • Remove the superstitious version number restraint.

/cc @philipturnbull who fuzzed this for me to help point the way.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with #3846, I trust your C/Flex skills over mine 😄

@kivikakk kivikakk merged commit c9b3d19 into master Nov 10, 2017
@kivikakk kivikakk deleted the kivikakk/lexer-fix branch November 10, 2017 11:11
@kivikakk
Copy link
Contributor Author

@lildude Thank you! 🙇‍♀️

@kivikakk kivikakk mentioned this pull request Nov 13, 2017
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants