fix connection validation with breakouts + unit tests #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edipascale
force-pushed
the
ema/fix-mclag-validate-breakout
branch
from
25e25e4 to
caba749
Compare
|
🚀 Temp artifacts published: |
tests were expected to fail, but they were failing for the wrong reasons - e.g missing profiles, invalid ports etc. fix them and add some test cases with no error to make sure everything works as expected Signed-off-by: Emanuele Di Pascale <[email protected]>
cannot use the parent port if children are busy, but disjoint sets of children should be allowed. add unit tests for these cases Signed-off-by: Emanuele Di Pascale <[email protected]>
edipascale
force-pushed
the
ema/fix-mclag-validate-breakout
branch
from
caba749 to
325e4fe
Compare
|
🚀 Temp artifacts published: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1228
Fix #816