(Naga) Implement OpImageGather and OpImageDrefGather when ingesting SPIR-V #8280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasenbanck
force-pushed
the
spirv-gather
branch
from
09da3a2 to
5dd7584
Compare
cwfitzgerald
approved these changes
Sep 29, 2025
Member
There was a problem hiding this comment.
This is a very minor nit - lets use gather-cmp instead of gather.cmp; the later implies that there's something about this file which isa comparison, as opposed to testing a comparison feature in slang.
hasenbanck
force-pushed
the
spirv-gather
branch
from
5dd7584 to
ee5fbef
Compare
hasenbanck
force-pushed
the
spirv-gather
branch
from
ee5fbef to
179e455
Compare
Contributor
Author
|
Applied suggested fixes and then rebase against trunk. |
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #4538
Description
Implements OpImageGather and OpImageDrefGather when ingesting SPIR-V.
Testing
Snapshot test
Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.