Added config file management #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Any news ? |
channing
reviewed
Oct 1, 2025
Contributor
channing
left a comment
channing
left a comment
There was a problem hiding this comment.
Thanks for the contribution @ZuluPro, and sorry for the late response!
I appreciate you tackling the persistent configuration problem. However, on macOS, apps shouldn't create custom files in the home directory. The standard approach would be to use UserDefaults (simplest) or the Application Support directory (~/Library/Application Support/). The ~/.config/ pattern is more of a Linux convention.
For this use case, I'd recommend using @AppStorage - it's built into SwiftUI and handles persistence automatically:
@AppStorage("serverHost") var host = "127.0.0.1"
@AppStorage("serverPort") var port = 11535| func readConfiguration() -> ServerConfiguration { | ||
| let homeDir = FileManager.default.homeDirectoryForCurrentUser | ||
| let configDir = homeDir.appendingPathComponent(".config") | ||
| let configFile = homeDir.appendingPathComponent("apple-on-device.json") |
Contributor
There was a problem hiding this comment.
Should use configDir, not homeDir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add the reading of a configuration file in ~/.config/apple-on-device.json.
Why
I need to reconfigure the IP/Port at each start of the app
How
At startup, the app try to read ~/.config/apple-on-device.json,
If it not exist, it creates it with the default configuration.
Then the file's configuration is used for define the original one.
Comments
It's my 1st swift contribution,
I may not be aware of anything important
Future
I also need a persitent memory to be able to let users define their Tools