ref: Introduce unmangled Name and better DemangleOptions #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
requested changes
Oct 1, 2020
flub
approved these changes
Oct 1, 2020
Swatinem
force-pushed
the
ref/demangle-options
branch
from
0686fb2 to
178df33
Compare
Contributor
Author
|
I changed the |
jan-auer
reviewed
Oct 13, 2020
Swatinem
force-pushed
the
ref/demangle-options
branch
from
178df33 to
33177b0
Compare
jan-auer
reviewed
Oct 14, 2020
Member
jan-auer
left a comment
jan-auer
left a comment
There was a problem hiding this comment.
Could you also update BreakpadFunctionIterator to return NameMangling::Unmangled? Breakpad files never contain mangled symbols as per definition.
DemangleOptions now takes explicit flags with support for arguments and return types
Swatinem
force-pushed
the
ref/demangle-options
branch
from
02b0581 to
5a8ec29
Compare
jan-auer
approved these changes
Oct 29, 2020
Contributor
Author
|
talked with jan: rename |
jan-auer
added a commit
that referenced
this pull request
Nov 17, 2020
* master: (22 commits) fix(debuginfo): Update dmsort to 1.0.1 to avoid panic due to UB (#287) ci: Use GHA instead of zeus (#286) ref: Introduce explicit NameMangling and better DemangleOptions (#275) meta: Bump all semver-major dependencies (#283) feat(demangle): Update swift demangler to 5.3 (#282) ref: Add File/FunctionIterator and lifetimes to DebugSession (#279) fix: Implement new clippy advice (#280) fix: Add a SymbolIterator and Lifetimes to ObjectLike trait (#277) ci: Switch to GitHub Actions (#273) ref: Introduce feature flags for demangling languages (#274) ref(common): Change InstructionInfo setters to Option (#272) ref: Remove all deprecated items (#271) ref: Replace failure with std::error::Error (#264) ref: Remove deprecated proguard support (#267) build: Reorganize the workspace (#266) build(unreal): Rename with-serde to serde (#265) fix(debuginfo): Detect mangled anonymous namespaces in PDB inlinees (#261) release: 7.5.0 meta: Update changelog for 7.5.0 feat: Unsafe transmute for PDB symbols (#258) ...
jan-auer
added a commit
that referenced
this pull request
Dec 22, 2020
* master: (21 commits) fix: New nightly clippy lint (#295) fix(release): Do not publish examples to crates.io release: 8.0.0 ref(debuginfo): Remove re-exports of error types (#300) meta: Update changelog ref(debuginfo): Switch to error with kind (#299) ref(minidump): Switch to error with kind (#298) ref(unreal): Switch to error with kind (#297) ref(symcache): Switch to error with kind (#296) feat: Rename architecture to wasm32 (#294) fix(debuginfo): Prefer DWARF names for Dart functions (#293) fix: clippy (#292) hack(dwarf): Skip line program sequences at 0 (#291) feat(wasm): support for wasm (#166) ci: Run rust nighlty on a schedule (#289) ref: Updates for rust 1.48 (#288) fix(debuginfo): Update dmsort to 1.0.1 to avoid panic due to UB (#287) ci: Use GHA instead of zeus (#286) ref: Introduce explicit NameMangling and better DemangleOptions (#275) meta: Bump all semver-major dependencies (#283) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DemangleOptions now takes explicit flags with support for arguments and return types.