Skip to content

feat(autofix): Track if autofix state is fetched through endpoint or elsewhere #93088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 10, 2025

Conversation

roaga
Copy link
Member

@roaga roaga commented Jun 8, 2025

Tracking if a user is viewing the state or the state is just being accessed by the sentry backend. Will be used for stopping automated runs if the user is looking at it.

Frontend PR to set flag: #93168

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 8, 2025
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93088      +/-   ##
==========================================
+ Coverage   85.41%   87.91%   +2.49%     
==========================================
  Files       10295    10308      +13     
  Lines      591158   591832     +674     
  Branches    23008    22969      -39     
==========================================
+ Hits       504944   520288   +15344     
+ Misses      85778    71108   -14670     
  Partials      436      436              

@roaga roaga requested a review from jennmueng June 9, 2025 13:53
@roaga roaga marked this pull request as ready for review June 9, 2025 13:53
@roaga roaga requested a review from a team as a code owner June 9, 2025 13:53
Comment on lines 69 to 71
autofix_state = get_autofix_state(
group_id=group.id, check_repo_access=check_repo_access, is_user_fetching=True
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, with this, just opening an issue details page will stop a PR from being made right? To continue off my comment in the seer PR, maybe if I'm staring at the drawer it would be better to stop, but if I just glance at an issue and if I have this setting on would make more sense to still go to the PR.

Anyways not a strong opinion, feel free to push back

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will update this to set the "is_user_fetching" based on a flag from the frontend so it only is set to true while looking at the drawer

@roaga roaga merged commit 39b4207 into master Jun 10, 2025
62 checks passed
@roaga roaga deleted the autofix/auto-coding branch June 10, 2025 15:56
Copy link

sentry-io bot commented Jun 10, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants