-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(autofix): Track if autofix state is fetched through endpoint or elsewhere #93088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93088 +/- ##
==========================================
+ Coverage 85.41% 87.91% +2.49%
==========================================
Files 10295 10308 +13
Lines 591158 591832 +674
Branches 23008 22969 -39
==========================================
+ Hits 504944 520288 +15344
+ Misses 85778 71108 -14670
Partials 436 436 |
autofix_state = get_autofix_state( | ||
group_id=group.id, check_repo_access=check_repo_access, is_user_fetching=True | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, with this, just opening an issue details page will stop a PR from being made right? To continue off my comment in the seer PR, maybe if I'm staring at the drawer it would be better to stop, but if I just glance at an issue and if I have this setting on would make more sense to still go to the PR.
Anyways not a strong opinion, feel free to push back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok will update this to set the "is_user_fetching" based on a flag from the frontend so it only is set to true while looking at the drawer
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Tracking if a user is viewing the state or the state is just being accessed by the sentry backend. Will be used for stopping automated runs if the user is looking at it.
Frontend PR to set flag: #93168