Skip to content

feat(uptime): Change Monitor Creation page title #93061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(uptime): Change Monitor Creation page title #93061

wants to merge 2 commits into from

Conversation

smeubank
Copy link
Member

@smeubank smeubank commented Jun 6, 2025

Make title of the page more specific to uptime monitor creation

@smeubank
Change page title
fb711ab 
Make title of the page more specific to uptime monitor creation
@smeubank smeubank requested a review from a team as a code owner June 6, 2025 20:31
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2025
@smeubank smeubank changed the title Change page title feat(uptime): Change Monitor Creation page title Jun 6, 2025
@smeubank smeubank mentioned this pull request Jun 6, 2025
Closed
evanpurkhiser
evanpurkhiser reviewed Jun 9, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

❌ 18 Tests Failed:

Tests completed Failed Passed Skipped
10525 18 10507 9
View the top 3 failed test(s) by shortest run time 
ProjectAlertsCreate test incompatible conditions test any filterMatch
Stack Traces | 0.014s run time 
ReferenceError: TITLES is not defined
    at Create (.../views/alerts/create.tsx:97:17)
    at Object.react-stack-bottom-frame (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:23863:20)
    at renderWithHooks (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:5529:22)
    at updateFunctionComponent (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:8897:19)
    at beginWork (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:10522:18)
    at runWithFiberInDEV (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:1522:13)
    at performUnitOfWork (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:15140:22)
    at workLoopSync (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:14956:41)
    at renderRootSync (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:14936:11)
    at performWorkOnRoot (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:14462:44)
    at performWorkOnRootViaSchedulerTask (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:16216:7)
    at flushActQueue (.../sentry/node_modules/.pnpm/[email protected]..../react/cjs/react.development.js:566:34)
    at Object.<anonymous>.process.env.NODE_ENV.exports.act (.../sentry/node_modules/.pnpm/[email protected]..../react/cjs/react.development.js:859:10)
    at .../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_acd753a47f69d22c76ca69960566dda2/node_modules/@.../react/dist/act-compat.js:47:25
    at renderRoot (.../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_acd753a47f69d22c76ca69960566dda2/node_modules/@.../react/dist/pure.js:188:26)
    at Object.render (.../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_acd753a47f69d22c76ca69960566dda2/node_modules/@.../react/dist/pure.js:287:10)
    at render (.../js/sentry-test/reactTestingLibrary.tsx:293:28)
    at createWrapper (.../views/alerts/create.spec.tsx:112:53)
    at Object.<anonymous> (.../views/alerts/create.spec.tsx:542:7)
    at Promise.then.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:121:9)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:106:12)
ProjectAlertsCreate Issue Alert can remove triggers
Stack Traces | 0.015s run time 
ReferenceError: TITLES is not defined
    at Create (.../views/alerts/create.tsx:97:17)
    at Object.react-stack-bottom-frame (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:23863:20)
    at renderWithHooks (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:5529:22)
    at updateFunctionComponent (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:8897:19)
    at beginWork (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:10522:18)
    at runWithFiberInDEV (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:1522:13)
    at performUnitOfWork (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:15140:22)
    at workLoopSync (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:14956:41)
    at renderRootSync (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:14936:11)
    at performWorkOnRoot (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:14462:44)
    at performWorkOnRootViaSchedulerTask (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:16216:7)
    at flushActQueue (.../sentry/node_modules/.pnpm/[email protected]..../react/cjs/react.development.js:566:34)
    at Object.<anonymous>.process.env.NODE_ENV.exports.act (.../sentry/node_modules/.pnpm/[email protected]..../react/cjs/react.development.js:859:10)
    at .../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_acd753a47f69d22c76ca69960566dda2/node_modules/@.../react/dist/act-compat.js:47:25
    at renderRoot (.../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_acd753a47f69d22c76ca69960566dda2/node_modules/@.../react/dist/pure.js:188:26)
    at Object.render (.../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_acd753a47f69d22c76ca69960566dda2/node_modules/@.../react/dist/pure.js:287:10)
    at render (.../js/sentry-test/reactTestingLibrary.tsx:293:28)
    at createWrapper (.../views/alerts/create.spec.tsx:112:53)
    at Object.<anonymous> (.../views/alerts/create.spec.tsx:205:11)
    at Promise.then.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:121:9)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:106:12)
ProjectAlertsCreate displays noisy alert checkbox for no conditions + filters
Stack Traces | 0.015s run time 
ReferenceError: TITLES is not defined
    at Create (.../views/alerts/create.tsx:97:17)
    at Object.react-stack-bottom-frame (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:23863:20)
    at renderWithHooks (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:5529:22)
    at updateFunctionComponent (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:8897:19)
    at beginWork (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:10522:18)
    at runWithFiberInDEV (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:1522:13)
    at performUnitOfWork (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:15140:22)
    at workLoopSync (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:14956:41)
    at renderRootSync (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:14936:11)
    at performWorkOnRoot (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:14462:44)
    at performWorkOnRootViaSchedulerTask (.../sentry/node_modules/.pnpm/[email protected][email protected]..../react-dom/cjs/react-dom-client.development.js:16216:7)
    at flushActQueue (.../sentry/node_modules/.pnpm/[email protected]..../react/cjs/react.development.js:566:34)
    at Object.<anonymous>.process.env.NODE_ENV.exports.act (.../sentry/node_modules/.pnpm/[email protected]..../react/cjs/react.development.js:859:10)
    at .../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_acd753a47f69d22c76ca69960566dda2/node_modules/@.../react/dist/act-compat.js:47:25
    at renderRoot (.../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_acd753a47f69d22c76ca69960566dda2/node_modules/@.../react/dist/pure.js:188:26)
    at Object.render (.../sentry/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@type_acd753a47f69d22c76ca69960566dda2/node_modules/@.../react/dist/pure.js:287:10)
    at render (.../js/sentry-test/reactTestingLibrary.tsx:293:28)
    at createWrapper (.../views/alerts/create.spec.tsx:112:53)
    at Object.<anonymous> (.../views/alerts/create.spec.tsx:571:5)
    at Promise.then.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:121:9)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smeubank @evanpurkhiser