-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
build: use node type transform #93036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build: use node type transform
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
If #93080 lands first, I will drop the experimental flags from this PR, else I'll drop them after |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93036 +/- ##
==========================================
+ Coverage 87.89% 87.96% +0.07%
==========================================
Files 10296 10299 +3
Lines 591054 591234 +180
Branches 22983 22972 -11
==========================================
+ Hits 519487 520068 +581
+ Misses 71131 70719 -412
- Partials 436 447 +11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense to me! Blocked by #93080, right?
@natemoo-re this one is good! Once we upgrade to 24, we can remove the experimental flag, but this should be good to go! |
If we bump to node v24.0 which is now LTS we can also drop the --experimental flag. I've pinged dev-infra about what the right way to do this is, and will update the PR or open a new one to just drop the flag in case this one gets merged sooner.
If we bump to node v24.0 which is now LTS we can also drop the --experimental flag. I've pinged dev-infra about what the right way to do this is, and will update the PR or open a new one to just drop the flag in case this one gets merged sooner.