-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(replays): reduce bottom bar #104246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ref(replays): reduce bottom bar #104246
Conversation
- Adjusted the dimensions of placeholders in various components for consistency. - Updated padding in the header for improved layout. - Refactored ReplayDetailsUserBadge to utilize a new layout structure and link query handling. - Added Flex container to enhance loading state presentation in ReplayDetailsMetadata. These changes aim to enhance the UI and maintain a cohesive design across replay components.
…ation Modified ReplayPreviewPlayer and ReplayTable components to utilize linkQuery for constructing navigation paths. This change enhances the clarity of the code and ensures consistent handling of query parameters across replay-related components.
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…replay-ui-3-shrink-bottom-header-4
…ation (#104247) > Related to [REPLAY-814: Implement new UI for Replay Page](https://linear.app/getsentry/issue/REPLAY-814/implement-new-ui-for-replay-page) Change columns to support generic link objects. This is used in #104246 to maintain the user email search feature.
… and update styling in replayMetaData
…yling in timestamp display
| columnIndex={0} | ||
| showDropdownFilters={false} | ||
| to={linkQuery} | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Analytics event incorrectly tracks navigation direction
The ReplaySessionColumn.Component is designed for replay list tables and fires trackAnalytics('replay.list-navigate-to-details', ...) with referrer_table: 'main' on click. When reused in the replay details header, this tracks the wrong event - the actual navigation is from the details page to the list page (when searchQuery exists), not list to details. The original code had no analytics tracking on this link, so the PR introduces misleading analytics data.
…rom ReplaySessionColumn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| platform: project?.platform, | ||
| organization, | ||
| referrer, | ||
| referrer_table: 'main', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we get rid of referrer_table?

Depends on #104247
This updates the bottom bar to