Skip to content

Conversation

@jerryzhou196
Copy link
Member

@jerryzhou196 jerryzhou196 commented Dec 2, 2025

Related to REPLAY-814: Implement new UI for Replay Page

Depends on #104247

This updates the bottom bar to

  • Reuse the ReplaySessionColumn
  • Resizes placeholder spaces accordingly

- Adjusted the dimensions of placeholders in various components for consistency.
- Updated padding in the header for improved layout.
- Refactored ReplayDetailsUserBadge to utilize a new layout structure and link query handling.
- Added Flex container to enhance loading state presentation in ReplayDetailsMetadata.

These changes aim to enhance the UI and maintain a cohesive design across replay components.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 2, 2025
…ation

Modified ReplayPreviewPlayer and ReplayTable components to utilize linkQuery for constructing navigation paths. This change enhances the clarity of the code and ensures consistent handling of query parameters across replay-related components.
@codecov
Copy link

codecov bot commented Dec 2, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
12741 2 12739 10
View the top 2 failed test(s) by shortest run time
replayDetailsUserBadge should hide LIVE badge when last received segment is more than 5 minutes ago
Stack Traces | 0.054s run time
Error: expect(received).toBeVisible()

received value must be an HTMLElement or an SVGElement.
Received has value: null
    at __EXTERNAL_MATCHER_TRAP__ (.../sentry/node_modules/.pnpm/[email protected]..../expect/build/index.js:2237:22)
    at Object.throwingMatcher [as toBeVisible] (.../sentry/node_modules/.pnpm/[email protected]..../expect/build/index.js:2238:6)
    at Object.toBeVisible (.../detail/header/replayDetailsUserBadge.spec.tsx:305:48)
replayDetailsUserBadge should show LIVE badge when last received segment is within 5 minutes
Stack Traces | 0.07s run time
Error: expect(received).toBeVisible()

received value must be an HTMLElement or an SVGElement.
Received has value: null
    at __EXTERNAL_MATCHER_TRAP__ (.../sentry/node_modules/.pnpm/[email protected]..../expect/build/index.js:2237:22)
    at Object.throwingMatcher [as toBeVisible] (.../sentry/node_modules/.pnpm/[email protected]..../expect/build/index.js:2238:6)
    at Object.toBeVisible (.../detail/header/replayDetailsUserBadge.spec.tsx:238:48)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@linear
Copy link

linear bot commented Dec 2, 2025

jerryzhou196 added a commit that referenced this pull request Dec 2, 2025
…ation (#104247)

> Related to [REPLAY-814: Implement new UI for Replay
Page](https://linear.app/getsentry/issue/REPLAY-814/implement-new-ui-for-replay-page)

Change columns to support generic link objects. This is used in #104246
to maintain the user email search feature.
@jerryzhou196 jerryzhou196 marked this pull request as ready for review December 11, 2025 01:45
@jerryzhou196 jerryzhou196 requested a review from a team as a code owner December 11, 2025 01:45
columnIndex={0}
showDropdownFilters={false}
to={linkQuery}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Analytics event incorrectly tracks navigation direction

The ReplaySessionColumn.Component is designed for replay list tables and fires trackAnalytics('replay.list-navigate-to-details', ...) with referrer_table: 'main' on click. When reused in the replay details header, this tracks the wrong event - the actual navigation is from the details page to the list page (when searchQuery exists), not list to details. The original code had no analytics tracking on this link, so the PR introduces misleading analytics data.

Fix in Cursor Fix in Web

Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCR-20251211-koxg

with the new styling, it's less obvious that the header is a link (to the search) -- does this matter?

platform: project?.platform,
organization,
referrer,
referrer_table: 'main',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we get rid of referrer_table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants