feat(loguru): Sentry logs for Loguru #4445

sentrivana · 2025-06-05T11:05:35Z

Allow to send Loguru logs to Sentry.

We can't parametrize them nicely, but this is a good first step.

Also:

Move some tests around. Tests specific to the stdlib logging integration were moved from the generic sentry logs tests to the logging integration tests.
Remove @minimum_python_37 from some tests that don't need 3.7+.
Dedupe some code by moving it to a superclass (_LoguruBaseHandler)

Closes #4151

codecov · 2025-06-05T11:06:47Z

Codecov Report

Attention: Patch coverage is 71.42857% with 18 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (4420c4d) to head (61f6395).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
sentry_sdk/integrations/loguru.py	70.21%	4 Missing and 10 partials ⚠️
sentry_sdk/logger.py	63.63%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4445      +/-   ##
==========================================
- Coverage   80.68%   80.60%   -0.08%     
==========================================
  Files         142      142              
  Lines       15986    16030      +44     
  Branches     2732     2745      +13     
==========================================
+ Hits        12898    12921      +23     
- Misses       2231     2243      +12     
- Partials      857      866       +9

Files with missing lines	Coverage Δ
sentry_sdk/integrations/logging.py	`83.66% <100.00%> (+0.96%)`	⬆️
sentry_sdk/logger.py	`87.09% <63.63%> (-12.91%)`	⬇️
sentry_sdk/integrations/loguru.py	`80.64% <70.21%> (-7.08%)`	⬇️

... and 4 files with indirect coverage changes

sentrivana · 2025-06-06T08:27:14Z

tests/integrations/logging/test_logging.py

@@ -283,3 +286,197 @@ def test_logging_dictionary_args(sentry_init, capture_events):
        == "the value of foo is bar, and the value of bar is baz"
    )
    assert event["logentry"]["params"] == {"foo": "bar", "bar": "baz"}
+
+
+def test_sentry_logs_warning(sentry_init, capture_envelopes):


These were just moved to this file from tests/test_logs.py

thanks for letting me know, not checking them further in that case

sentrivana · 2025-06-06T09:06:27Z

Additional change: removed setting sentry.message.template since we can't take apart Loguru logs at the moment.

szokeasaurusrex

Looks mostly good, I did have a PII concern though which is why I am not approving yet (please see the inline comment which mentions this, in the loguru.py file).

The other comments are just minor suggestions/nits which you can feel free to ignore, once the PII thing is addressed I will approve.

sentry_sdk/integrations/logging.py

sentry_sdk/integrations/loguru.py

szokeasaurusrex · 2025-06-10T08:11:48Z

sentry_sdk/integrations/loguru.py

+    for py_level, otel_severity_number, otel_severity_text in [
+        (LoggingLevels.CRITICAL, 21, "fatal"),
+        (LoggingLevels.ERROR, 17, "error"),
+        (LoggingLevels.WARNING, 13, "warn"),
+        (LoggingLevels.SUCCESS, 11, "info"),
+        (LoggingLevels.INFO, 9, "info"),
+        (LoggingLevels.DEBUG, 5, "debug"),
+        (LoggingLevels.TRACE, 1, "trace"),
+    ]:
+        if record_level >= py_level:
+            return otel_severity_number, otel_severity_text
+


[suggestion for future PR] might be worth extracting this logic into a separate funciton, especially if we expect to add more logging integrations that would use it; seems to be verbatim repeated from the logging integration.

We may also or alternatively want to make constants for the OTel severity numbers, since these are hardcoded in both locations (this can also be done in separate PR)

It's not exactly the same as in the logging integration, Loguru has two additional logging levels (SUCCESS and TRACE iirc). But it would definitely be nice to have the logic in a separate function and only define the mapping itself in each integration. Will do this.

The brunt of the changes is in this commit
mypy is unhappy, fixing that separately

sentry_sdk/integrations/loguru.py

szokeasaurusrex · 2025-06-10T08:27:16Z

tests/integrations/logging/test_logging.py

@@ -283,3 +286,197 @@ def test_logging_dictionary_args(sentry_init, capture_events):
        == "the value of foo is bar, and the value of bar is baz"
    )
    assert event["logentry"]["params"] == {"foo": "bar", "bar": "baz"}
+
+
+def test_sentry_logs_warning(sentry_init, capture_envelopes):


thanks for letting me know, not checking them further in that case

szokeasaurusrex · 2025-06-10T08:28:44Z

tests/integrations/loguru/test_loguru.py

@@ -54,7 +59,7 @@ def test_just_log(
    formatted_message = (
        " | "
        + "{:9}".format(level.name.upper())
-        + "| tests.integrations.loguru.test_loguru:test_just_log:52 - test"
+        + "| tests.integrations.loguru.test_loguru:test_just_log:57 - test"


It's kinda gonna be a pain to maintain this if we might add/remove imports in the future. Perhaps we could just check that the value here is an int? Or maybe there is some fancy introspection logic we could use to compute the line?

We can also address this in a separate PR, I guess it's not exactly in scope here to fix

I didn't add this, it was already there -- agree with you on it being annoying, but not in scope. We can improve this some other time.

CHANGELOG.md

Co-authored-by: Daniel Szoke <[email protected]>

sentrivana · 2025-06-10T12:01:34Z

sentry_sdk/integrations/logging.py

-        (30, 13, "warn"),
-        (20, 9, "info"),
-        (10, 5, "debug"),
-        (5, 1, "trace"),


This (5, 1, "trace") is now missing from the new mapping in SEVERITY_TO_OTEL_SEVERITY. There is no level 5 in the stdlib logging library

szokeasaurusrex · 2025-06-10T12:42:30Z

sentry_sdk/logger.py

@@ -6,6 +6,16 @@
 from sentry_sdk import get_client
 from sentry_sdk.utils import safe_repr

+OTEL_RANGES = [
+    # ((severity level range), severity text)
+    ((1, 4), "trace"),


[optional suggestion] This is completely fine as is, but if you want, you could make all of these into ranges, then rather than manually checking if the severity number is in between the bounds, you would just check if it is in the range.

Suggested change

((1, 4), "trace"),

(range(1, 5), "trace"),

I'd prefer to keep as is, since that way the ranges correspond to OTel levels exactly as they're written in code (i.e., you don't need to make the extra effort in your head to decrement the last number of each range by one to arrive at the actual range)

szokeasaurusrex · 2025-06-10T12:43:43Z

sentry_sdk/logger.py

+    for (lower, upper), severity in OTEL_RANGES:
+        if lower <= otel_severity_number <= upper:
+            return severity


If you take my suggestion about ranges

Suggested change

for (lower, upper), severity in OTEL_RANGES:

if lower <= otel_severity_number <= upper:

return severity

for severity_range, severity in OTEL_RANGES:

if otel_severity_number in severity_range:

return severity

sentry_sdk/integrations/loguru.py

szokeasaurusrex · 2025-06-10T12:49:40Z

lgtm! maybe check the codecov/patch failure before merging to see if test coverage should be expanded

sentrivana · 2025-06-10T14:26:23Z

Added a small test, will merge now

sentrivana added 5 commits June 2, 2025 15:09

feat(loguru): Support Sentry logs

f992680

.

1be8d9a

.

3824524

.

96a0f2b

.

062de97

sentrivana added 15 commits June 5, 2025 13:07

Merge branch 'master' into ivana/loguru-logs

31b868d

do we need this?

1d74c18

unused import

f48d293

wut py3.6

a15716e

comment

0b15f29

.

a377c54

mypy

e66c0c2

.

ac6dd2d

Merge branch 'master' into ivana/loguru-logs

b8bd5ef

.

88cb4d7

more tests

05ccc59

typing

2c8be6c

more typing

fab0fba

.

a6b083b

.

1a35e02

sentrivana commented Jun 6, 2025

View reviewed changes

another test

f26fc8c

sentrivana marked this pull request as ready for review June 6, 2025 08:50

sentrivana requested a review from a team as a code owner June 6, 2025 08:50

remove template

8397b10

szokeasaurusrex reviewed Jun 10, 2025

View reviewed changes

sentrivana and others added 2 commits June 10, 2025 10:44

Apply suggestions from code review

e3670f9

Co-authored-by: Daniel Szoke <[email protected]>

Move otel severity mapping logic

eb8e5a4

Merge branch 'master' into ivana/loguru-logs

fc2f1bd

sentrivana commented Jun 10, 2025

View reviewed changes

mypy

cfac8d7

sentrivana requested a review from szokeasaurusrex June 10, 2025 12:17

szokeasaurusrex mentioned this pull request Jun 10, 2025

Remove hardcoded line number in Loguru tests #4454

Open

szokeasaurusrex reviewed Jun 10, 2025

View reviewed changes

szokeasaurusrex approved these changes Jun 10, 2025

View reviewed changes

sentry_sdk/integrations/loguru.py Show resolved Hide resolved

szokeasaurusrex approved these changes Jun 10, 2025

View reviewed changes

add test

61f6395

sentrivana merged commit 51db87c into master Jun 10, 2025
136 of 137 checks passed

sentrivana deleted the ivana/loguru-logs branch June 10, 2025 14:26

feat(loguru): Sentry logs for Loguru #4445

feat(loguru): Sentry logs for Loguru #4445

Uh oh!

Conversation

sentrivana commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sentrivana commented Jun 6, 2025

Uh oh!

szokeasaurusrex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sentrivana Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

szokeasaurusrex commented Jun 10, 2025

Uh oh!

sentrivana commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

sentrivana commented Jun 5, 2025 •

edited

Loading

codecov bot commented Jun 5, 2025 •

edited

Loading

sentrivana Jun 10, 2025 •

edited

Loading