Skip to content

feat(scope): Replace transaction with root_span #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

feat(scope): Replace transaction with root_span #4263

merged 2 commits into from
Apr 10, 2025

Conversation

szokeasaurusrex
Copy link
Member

Closes #4235

@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner April 9, 2025 14:59
@szokeasaurusrex szokeasaurusrex requested review from sentrivana and removed request for a team April 9, 2025 14:59
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transaction-root-span branch 2 times, most recently from 0d2a99e to 0c37864 Compare April 9, 2025 15:10
@codecov Codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
20807 1 20806 4420
View the top 1 failed test(s) by shortest run time 
tests.test_basics test_classmethod_tracing
Stack Traces | 0.156s run time 
tests/test_basics.py:811: in test_classmethod_tracing
    assert fake_start_child.call_count == 1
E   AssertionError: assert 3 == 1
E    +  where 3 = <MagicMock name='mock.start_child' id='140147341238688'>.call_count
View the full list of 1 ❄️ flaky tests 
tests.test_basics test_classmethod_tracing

Flake rate in main: 9.52% (Passed 19 times, Failed 2 times)

Stack Traces | 0.143s run time 
tests/test_basics.py:811: in test_classmethod_tracing
    assert fake_start_child.call_count == 1
E   AssertionError: assert 2 == 1
E    +  where 2 = <MagicMock name='mock.start_child' id='139729590414112'>.call_count

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transaction-root-span branch 3 times, most recently from c31dfab to 7f14b64 Compare April 10, 2025 11:28
szokeasaurusrex added a commit that referenced this pull request Apr 10, 2025
@szokeasaurusrex
ref(scope): Properly type Scope.root_span
cbce9ed 
Currently, this property has type `Any`, but it can now be changed to `Optional[Span]`

Depends on:
  - #4263
@szokeasaurusrex szokeasaurusrex mentioned this pull request Apr 10, 2025
Merged
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

@szokeasaurusrex szokeasaurusrex mentioned this pull request Apr 10, 2025
Merged
szokeasaurusrex added a commit that referenced this pull request Apr 10, 2025
@szokeasaurusrex
ref(scope): Properly type Scope.root_span
6d441a1 
Currently, this property has type `Any`, but it can now be changed to `Optional[Span]`

Depends on:
  - #4263
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transaction-root-span branch from 7f14b64 to b30574a Compare April 10, 2025 12:28
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner April 10, 2025 12:28
sentrivana
sentrivana approved these changes Apr 10, 2025
View reviewed changes
@szokeasaurusrex @sentrivana
Update MIGRATION_GUIDE.md
dd7fb8d 
Co-authored-by: Ivana Kellyer <[email protected]>
@szokeasaurusrex szokeasaurusrex merged commit ab802b5 into potel-base Apr 10, 2025
126 of 127 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/transaction-root-span branch April 10, 2025 13:17
antonpirker pushed a commit that referenced this pull request Apr 24, 2025
@szokeasaurusrex
ref(scope): Properly type Scope.root_span (#4273)
4046951 
Currently, this property has type `Any`, but it can now be changed to
`Optional[Span]`

Depends on:
  - #4263
antonpirker pushed a commit that referenced this pull request Apr 24, 2025
@szokeasaurusrex
ref: Simplify Scope.root_span logic (#4274)
d4b9d50 
Depends on:
  - #4273
  - #4263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@sentrivana sentrivana sentrivana approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szokeasaurusrex @sentrivana