Skip to content

Drop metrics #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Drop metrics #3518

merged 2 commits into from
Sep 11, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 11, 2024

Just to reiterate, Sentry will stop accepting metrics on Oct 7. The next major of the SDK will take at least some weeks longer.

We have two options re: metrics:

  1. We leave the sentry_sdk.metrics APIs, but make them no-op
  2. We remove everything.

This PR does 2. I believe this is ok because:

  • We've deprecated metrics and are now emitting a warning about dropping them in the next major
  • They're in beta, so not generally available
  • We will call this out properly both in the detailed changelog as well as in the migration guide in the docs

Copy link

codecov bot commented Sep 11, 2024

❌ 3422 Tests Failed:

Tests completed Failed Passed Skipped
16606 3422 13184 1434
View the top 3 failed tests by shortest run time
tests.integrations.celery.test_celery test_producer_span_data[redis]
Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time
No failure message available
tests.integrations.httpx.test_httpx test_option_trace_propagation_targets[httpx_client14-trace_propagation_targets14-https://example.com-True]
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana marked this pull request as ready for review September 11, 2024 10:26
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest in Peace, metrics.

@sentrivana sentrivana merged commit 0653357 into potel-base Sep 11, 2024
9 of 108 checks passed
@sentrivana sentrivana deleted the ivana/potel/drop-metrics branch September 11, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants