-
-
Notifications
You must be signed in to change notification settings - Fork 51
feat: Add sentry-cli upload-dif action #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
# Conflicts: # CHANGELOG.md
|
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this? dumb question, but is this available to users yet or does it need to go through a release process first?
I clearly know how to use a keyboard, that was meant to be |
We need to do a release, but this is just a matter of minutes. |
great, so we can include it in the docs already. but let's wait for the default of the path first i guess |
As also mentioned here: 6203fc5#r54278929 |
Also (as mentioned here 6203fc5#commitcomment-54278944), |
@lhunath Thanks for the feedback, we will look into this. |
Overview
sentry_upload_dif
action.Testing
rspec
tests, testing the parameters and how they translate tosentry-cli
parameters.upload-dif
action.Relates to #86