Log sentry-cli output while the command is still running #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gets` will wait for more output to be produced if the stream is not yet closed. Since only stdout is forwarded, it should be handled before stderr, and logged to the user as it comes in. After the command has finished, stderr is read and buffered to completion.
|
CI failure looks unrelated to me |
|
@HazAT ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getswill wait for more output to be produced if the stream is notyet closed. Since only stdout is forwarded, it should be handled
before stderr, and logged to the user as it comes in. After the
command has finished, stderr is read and buffered to completion.