Feat(Session Replay): Replay Options #3674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coa into feat(SR)/ReplayEvent
brustolin
requested review from
armcknight and
philipphofmann
as code owners
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5583f7d | 1226.60 ms | 1248.15 ms | 21.54 ms |
| fdb13d4 | 1203.73 ms | 1211.39 ms | 7.66 ms |
| f5fef43 | 1207.51 ms | 1213.69 ms | 6.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5583f7d | 21.58 KiB | 430.59 KiB | 409.01 KiB |
| fdb13d4 | 21.58 KiB | 430.70 KiB | 409.12 KiB |
| f5fef43 | 21.58 KiB | 425.58 KiB | 403.99 KiB |
brustolin
changed the title
philipphofmann
approved these changes
Feb 22, 2024
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, thanks for putting this refactoring into an extra PR.
bruno-garcia
approved these changes
Feb 23, 2024
…y-cocoa into feat(SR)/replay-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings for session replay in the Options.
#skip-changelog