-
-
Notifications
You must be signed in to change notification settings - Fork 372
feat(Session Replay): Session Replay Integration #3671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 103 commits
Commits
Show all changes
104 commits
Select commit
Hold shift + click to select a range
663199a
Merge branch 'feat/session-replay' into feat(SR)/ReplayEvent
brustolin eae7f93
feat(Session Replay): ReplayEvent, ReplayRecording and Envelope handling
brustolin 7f7be69
Merge branch 'main' into feat(SR)/ReplayEvent
brustolin 37d92b3
Merge branch 'feat/session-replay' into feat(SR)/ReplayEvent
brustolin 9e21c1e
refactoring
brustolin ad347c3
SessionReplayIntegration
brustolin 723b074
MsgPack
brustolin d27ec15
Capture with scope
brustolin 665bec4
MsgPack Tests
brustolin f42c9e7
Format code
getsentry-bot 398e3d0
Replacing envelope item
brustolin ab57929
Merge branch 'feat(SR)/ReplayEvent' of github.com:getsentry/sentry-co…
brustolin 33ead44
more test
brustolin 6cd821e
Format code
getsentry-bot 216c42e
Hub test
brustolin 21efb9a
Update SentryHubTests.swift
brustolin b11fc9a
Merge branch 'feat(SR)/ReplayEvent' into feat(SR)/replay-integration
brustolin d6d8ce0
integration
brustolin 522e972
More tests and log messages
brustolin 522a5da
Format code
getsentry-bot 4463fed
CategoryMapper tests
brustolin b14f253
Update SentryMsgPackSerializer.m
brustolin 16b192d
Format code
getsentry-bot 3d37160
Format code
getsentry-bot b725be7
Clean Up PR
brustolin 5443cdc
Update SentryOptions.m
brustolin 32227b1
Test
brustolin a99524d
Revert "Clean Up PR"
brustolin cc5eadf
Fixing UIKIT references
brustolin 77066c7
fixing for tvos
brustolin e5e5b12
more fixes
brustolin 939a6c1
Update Sentry.h
brustolin 837c211
Update project.pbxproj
brustolin 2cab983
Merge branch 'feat/session-replay' into feat(SR)/ReplayEvent
brustolin a3f7a62
Merge branch 'feat(SR)/ReplayEvent' into feat(SR)/replay-settings
brustolin 00bb955
Merge branch 'feat(SR)/replay-settings' into feat(SR)/replay-integration
brustolin 77f6e42
fix for tvOS
brustolin 6f07d9e
Format code
getsentry-bot ec2bd0d
Merge branch 'feat/session-replay' into feat(SR)/replay-integration
brustolin 39f8f3d
adjust options
brustolin 19b1cec
Format code
getsentry-bot 78eb6bb
Update SentryViewPhotographer.m
brustolin 4edc54a
Merge branch 'feat(SR)/replay-integration' of github.com:getsentry/se…
brustolin 98ba250
Format code
getsentry-bot 369c117
Some fixes
brustolin 742c83b
Merge branch 'feat(SR)/replay-integration' of github.com:getsentry/se…
brustolin 46f04d8
tying everything
brustolin e8104c2
Merge branch 'feat/session-replay' into feat(SR)/replay-integration
brustolin 68dc4cd
WIP
brustolin 58d938d
Replay working
brustolin 9dbacfd
Format code
getsentry-bot f3d8336
using global processor
brustolin 1a07837
refactoring
brustolin 6add56e
more info in videoInfo
brustolin f648e93
More refactoring
brustolin e394969
Format code
getsentry-bot acddddc
context
brustolin 41806d5
Merge branch 'feat(SR)/replay-integration' of github.com:getsentry/se…
brustolin 0dc0d92
Format code
getsentry-bot 680fa70
Merge branch 'feat/session-replay' into feat(SR)/replay-integration
brustolin 049b933
fixed merging
brustolin 0521b22
wip
brustolin dd65044
Merge branch 'feat/session-replay' into feat(SR)/replay-integration
brustolin b55c88c
SessionReplayIntegration in swift
brustolin d261a3a
Update Package.swift
brustolin c46aae8
Update Package.swift
brustolin 649ff4b
Make it swift
brustolin 554e5ba
Update SentrySessionReplay.swift
brustolin 6c2db34
Update AppDelegate.swift
brustolin 97ea265
fixes
brustolin ba6c5a3
tests
brustolin 0da9473
Update SentryFileManager.m
brustolin 3252a83
Update Sentry.podspec
brustolin d8ce8d6
revert Session Replay
brustolin 1afd0d9
Reverting some things :(
brustolin 1612a21
Update Package.swift
brustolin 8fd5e30
Fixing CI
brustolin 0d26201
wip
brustolin 846a53a
restrict version
brustolin 355f627
replay for ios and tvos
brustolin 4376764
Update SentrySessionReplay.m
brustolin f2fd179
Check for UIKit
brustolin 2eec7ba
Update SentryReplayEventTests.swift
brustolin 693decf
fix tests
brustolin 9224a00
fixing references
brustolin 456e725
Update SentryOnDemandReplay.swift
brustolin 2b254d1
remove vision
brustolin a73feb1
Update SentryViewPhotographer.swift
brustolin 4b4e7b3
Update SentrySessionReplayIntegration.h
brustolin 5bdf0dd
tests
brustolin 55d376a
Update SentrySessionReplayIntegrationTests.swift
brustolin a1553fb
tests
brustolin d527f76
Apply suggestions from code review
brustolin f4045c9
wip
brustolin d1e50be
ref
brustolin 8c638c7
Revert "Update Sentry.podspec"
brustolin da03a69
Update Sentry.podspec
brustolin f36b11d
remove file size
brustolin c2d264f
Apply suggestions from code review
brustolin 98fec3b
NoUI config
brustolin c82c5f9
Merge branch 'feat(SR)/replay-integration' of github.com:getsentry/se…
brustolin 5543054
Update SentryReplayOptions.swift
brustolin 1a1405f
Update SentryOnDemandReplay.swift
brustolin 1f8f703
feat(Session Replay): Experimental Options (#3816)
brustolin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import _SentryPrivate | ||
| import Foundation | ||
|
|
||
| @objc | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #include "Sentry.xcconfig" | ||
|
|
||
| OTHER_SWIFT_FLAGS = -DSENTRY_NO_UIKIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| #import "SentryCoreGraphicsHelper.h" | ||
| #if SENTRY_HAS_UIKIT | ||
| @implementation SentryCoreGraphicsHelper | ||
| + (CGMutablePathRef)excludeRect:(CGRect)rectangle fromPath:(CGMutablePathRef)path | ||
| { | ||
| # if (TARGET_OS_IOS || TARGET_OS_TV) | ||
brustolin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # ifdef __IPHONE_16_0 | ||
| if (@available(iOS 16.0, tvOS 16.0, *)) { | ||
| CGPathRef exclude = CGPathCreateWithRect(rectangle, nil); | ||
| CGPathRef newPath = CGPathCreateCopyBySubtractingPath(path, exclude, YES); | ||
| return CGPathCreateMutableCopy(newPath); | ||
| } | ||
| # endif // defined(__IPHONE_16_0) | ||
| # endif // (TARGET_OS_IOS || TARGET_OS_TV) | ||
| return path; | ||
| } | ||
| @end | ||
| #endif // SENTRY_HAS_UIKIT | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,15 +15,14 @@ | |||||
| #import "SentryOptions+Private.h" | ||||||
| #import "SentrySDK.h" | ||||||
| #import "SentryScope.h" | ||||||
| #import "SentrySessionReplayIntegration.h" | ||||||
| #import "SentrySwiftAsyncIntegration.h" | ||||||
|
|
||||||
| #import <objc/runtime.h> | ||||||
|
|
||||||
| #if SENTRY_HAS_UIKIT | ||||||
| # import "SentryAppStartTrackingIntegration.h" | ||||||
| # import "SentryFramesTrackingIntegration.h" | ||||||
| # import "SentryPerformanceTrackingIntegration.h" | ||||||
| # import "SentryReplayOptions+Private.h" | ||||||
| # import "SentryScreenshotIntegration.h" | ||||||
| # import "SentryUIEventTrackingIntegration.h" | ||||||
| # import "SentryViewHierarchyIntegration.h" | ||||||
|
|
@@ -58,6 +57,9 @@ - (void)setMeasurement:(SentryMeasurementValue *)measurement | |||||
| NSStringFromClass([SentryUIEventTrackingIntegration class]), | ||||||
| NSStringFromClass([SentryViewHierarchyIntegration class]), | ||||||
| NSStringFromClass([SentryWatchdogTerminationTrackingIntegration class]), | ||||||
| # if !TARGET_OS_VISION | ||||||
| NSStringFromClass([SentrySessionReplayIntegration class]), | ||||||
| # endif | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| #endif // SENTRY_HAS_UIKIT | ||||||
| NSStringFromClass([SentryANRTrackingIntegration class]), | ||||||
| NSStringFromClass([SentryAutoBreadcrumbTrackingIntegration class]), | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.