Cookies handling is incorrect

[raszi]

Environment

io.sentry/sentry-clj "7.20.226"
org.clojure/clojure "1.12.0"

Steps to Reproduce

Send a request map with cookies set.

Expected Result

The cookies are correctly parsed and sent to Sentry.

Actual Result

java.lang.ClassCastException: class java.util.HashMap cannot be cast to class java.lang.String (java.util.HashMap and java.lang.String are in module java.base of loader 'bootstrap')
	at sentry_clj.core$map__GT_request.invokeStatic(core.clj:85)
	at sentry_clj.core$map__GT_request.invoke(core.clj:71)
	at sentry_clj.core$map__GT_event.invokeStatic(core.clj:139)
	at sentry_clj.core$map__GT_event.invoke(core.clj:113)
	at sentry_clj.core$send_event.invokeStatic(core.clj:365)
	at sentry_clj.core$send_event.invoke(core.clj:354)

Explanation

The map->request function handles the value of the :cookies key as a hashmap, and tries to pass that to the io.sentry.protocol.Request/setCookies method as a hasmap, but that method receives a String.

https://getsentry.github.io/sentry-java/io/sentry/protocol/Request.html#setCookies(java.lang.String)

[rutchkiwi]

Ran into this as well. Annnoying!

[dharrigan]

Hi,

I wonder if you could share an example of an event that is causing the issue. The function 'java-util-hashmappify-vals' checks to see if the passed in value is a map (or keyword) and returns the value as-is, if not either a map or keyword.

Considering that 'cookies', when deconstructed, is a string value, the function 'java-util-hashmappify-vals' should simply return the string.

I believe, also, the tests would blow up if a map was indeed being used to set the cookies value (and the test map->request-test tests this very thing).

Perhaps the event you are receiving contains the cookies as a map - thus I would be very curious to seen an example of the request containing the cookies please, to see if there is something that needs to change.

I'm using 8.0.228 btw (although the code hasn't changed in this area for 7.20.226).

Thank you

[rutchkiwi]

@dharrigan If you use https://ring-clojure.github.io/ring/ring.middleware.cookies.html like I and I think most people do. You'll get something like this:

(sentry/send-event {:request {:cookies {"foo" {:value "true"}}}})
                                        
Execution error (ClassCastException) at sentry-clj.core/map->request (core.clj:85).
class java.util.HashMap cannot be cast to class java.lang.String (java.util.HashMap and java.lang.String are in module java.base of loader 'bootstrap')

[dharrigan]

Right,

So, it's the fact that the cookies are being transformed by the ring middleware that causes the issue - that wasn't clear from the initial issue comment. Thank you for the clarification. I will look into it.

[rutchkiwi]

thanks for fixing this!