Update passwordGenerator.py #2719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Enhancements Made to Original Password Generator
π§ 1. Function Encapsulation
β’ Before: All code was in the global scope.
β’ After: Wrapped logic inside a generate_password() function to allow reuse and cleaner execution.
π 2. Random Country & Language
β’ Before: Only printed a list of countries; TODO was not implemented.
β’ After:
β’ Picks one random country using pycountry.countries.
β’ Picks one random language from pycountry.languages that has a valid name.
π² 3. Used random.choice()
β’ Before: Used randint(0, len(tuple) - 1), which is error-prone.
β’ After: Replaced with random.choice() for better readability and safety.
π§Ή 4. Cleaned Up Code Structure
β’ Removed redundant comments.
β’ Added clear, consistent variable naming.
β’ Grouped constants together at the top.
π 5. Casing Logic Simplified
β’ Before: Conditional casing inside if blocks.
β’ After: Used more readable logic with descriptive variable (case_choice as "upper_colour" or "upper_animal").
π 6. Unified Password Construction
β’ Created a single formatted password string:
"{colour}{number}{animal}{special}"
π§Ύ 7. Enhanced Output
β’ Print statements now show:
β’ The final password
β’ The country used
β’ The language used
β’ Clear labels for each