Add --no-lock flag to snapshot indexing operations #892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking "Index Snapshots" in the UI, Backrest calls
restic snapshots
to retrieve repository snapshot history. This operation could fail if another process had a lock on the repository, causing indexing operations to be blocked unnecessarily.This PR adds the
--no-lock
flag to snapshot indexing operations, which performs a read-only operation that won't conflict with other processes using the repository.Changes Made
RepoOrchestrator.Snapshots()
to accept variadicrestic.GenericOption
parameters for flexibilityindexSnapshotsHelper()
to pass the--no-lock
flag when callingrepo.Snapshots()
--no-lock
flag functionality works correctlyTechnical Details
The change modifies the snapshot indexing flow:
IndexSnapshots
API →NewOneoffIndexSnapshotsTask
→indexSnapshotsHelper
→repo.Snapshots(ctx, restic.WithFlags("--no-lock"))
This ensures that snapshot indexing operations use
restic snapshots --json --no-lock
instead ofrestic snapshots --json
, preventing lock conflicts during repository indexing while other backup or maintenance operations are running.Fixes #664.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.