Using io.ReadAll instead of ioutil.ReadAll #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gabriel-vasile merged 1 commit into gabriel-vasile:master from phihungtf:master

May 24, 2024

Contributor

phihungtf commented May 15, 2024

ioutil.ReadAll is deprecated: As of Go 1.16, this function simply calls [io.ReadAll]


          Using io.ReadAll instead of ioutil.ReadAll

4b7a539

gabriel-vasile merged commit 07821d3 into gabriel-vasile:master

pellared referenced this pull request in open-telemetry/opentelemetry-go-contrib


          chore(deps): update module github.com/gabriel-vasile/mimetype to v1.4…

1c0eae0

….4 (#5660)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/gabriel-vasile/mimetype](https://togithub.com/gabriel-vasile/mimetype)
| `v1.4.3` -> `v1.4.4` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgabriel-vasile%2fmimetype/v1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgabriel-vasile%2fmimetype/v1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgabriel-vasile%2fmimetype/v1.4.3/v1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgabriel-vasile%2fmimetype/v1.4.3/v1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>gabriel-vasile/mimetype
(github.com/gabriel-vasile/mimetype)</summary>

###
[`v1.4.4`](https://togithub.com/gabriel-vasile/mimetype/releases/tag/v1.4.4)

[Compare
Source](https://togithub.com/gabriel-vasile/mimetype/compare/v1.4.3...v1.4.4)

#### What's Changed

##### Security fixes:

Update `golang.org/x/net` to latest. Fixes:
[CVE-2023-45288](https://deps.dev/advisory/osv/GO-2024-2687)

##### Performance improvements:

- Change tar detection to use checksum instead of legal ranges of values
in
[https://github.com/gabriel-vasile/mimetype/pull/466](https://togithub.com/gabriel-vasile/mimetype/pull/466)
- ftyp: exit asap to prevent mem allocs in
[https://github.com/gabriel-vasile/mimetype/pull/517](https://togithub.com/gabriel-vasile/mimetype/pull/517)
- Improve x-subrip detection performance in
[https://github.com/gabriel-vasile/mimetype/pull/524](https://togithub.com/gabriel-vasile/mimetype/pull/524)
- improve performance for text detection in
[https://github.com/gabriel-vasile/mimetype/pull/532](https://togithub.com/gabriel-vasile/mimetype/pull/532)
- Using io.ReadAll instead of ioutil.ReadAll by
[@&#8203;phihungtf](https://togithub.com/phihungtf) in
[https://github.com/gabriel-vasile/mimetype/pull/525](https://togithub.com/gabriel-vasile/mimetype/pull/525)

Benchmarks:

```bash
before:
BenchmarkText/application/x-ndjson-8              663314              2027 ns/op            4306 B/op          6 allocs/op
BenchmarkSliceRand-8                              688160              1690 ns/op             728 B/op         75 allocs/op
BenchmarkSrt-8                                    946042              1089 ns/op            4240 B/op          5 allocs/op
after:
BenchmarkText/application/x-ndjson-8             1930292               678.6 ns/op           160 B/op          4 allocs/op
BenchmarkSliceRand-8                             1232066              1173 ns/op             160 B/op          4 allocs/op
BenchmarkSrt-8                                   3235448               368.8 ns/op            64 B/op          2 allocs/op
```

#### New Contributors

- [@&#8203;phihungtf](https://togithub.com/phihungtf) made their first
contribution in
[https://github.com/gabriel-vasile/mimetype/pull/525](https://togithub.com/gabriel-vasile/mimetype/pull/525)

**Full Changelog**:
gabriel-vasile/mimetype@v1.4.3...v1.4.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlNraXAgQ2hhbmdlbG9nIiwiZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet