Use Scaled Monitor Size For Monitor Detection

[cwarden]

Fix monitor detection by using the candidate monitor's scaled
dimensions.

Fixes bug in which scale changes prematurely as window gets near monitor with a different scale.

[andydotxyz]

Thanks for this. A comment inline about a potential tidy.

However a larger question... what are the return units?
We usually use int for pixels only but this is no longer a pixel size I don't think.
If it is back to regular Fyne coordinates then float32 is what we use.

[cwarden]

Thanks for this. A comment inline about a potential tidy.

However a larger question... what are the return units? We usually use int for pixels only but this is no longer a pixel size I don't think. If it is back to regular Fyne coordinates then float32 is what we use.

It is pixels. Here's layout I'm using where I ran into the issue.

The monitor on the left has a native resolution of 2560x1600, which is scaled to 1920x1200, the ~1.6 scaling. So the function should return (1920, 1200) for the first monitor. The other two are not scaled so it returns their native resolutions of (2560, 1440).

[cwarden]

Thanks for this. A comment inline about a potential tidy.
However a larger question... what are the return units? We usually use int for pixels only but this is no longer a pixel size I don't think. If it is back to regular Fyne coordinates then float32 is what we use.

It is pixels. Here's layout I'm using where I ran into the issue.

The monitor on the left has a native resolution of 2560x1600, which is scaled to 1920x1200, the ~1.6 scaling. So the function should return (1920, 1200) for the first monitor. The other two are not scaled so it returns their native resolutions of (2560, 1440).

Hmm, it's actually not returning (1920, 1200), but (1625, 1015). So I think you're right that these are Fyne coordinates. (My mental model of Fyne's scaling is clearly still incomplete.)

[coveralls]

coverage: 62.401% (+0.09%) from 62.31%
when pulling fc67f02 on cwarden:monitor-detection
into abab0ab on fyne-io:develop.

[andydotxyz]

Thanks so much!

[andydotxyz]

Thanks so much @cwarden and congratulations on landing your first Fyne code contribution :)