Skip to content

Add cy files to our overrides for tests and non-production code to not include our extra rules that are not needed for that #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

FSVetaz
Copy link
Contributor

@FSVetaz FSVetaz commented Sep 27, 2024

For example, we don't need to add test selectors for buttons in our cy tests.

This will make it so we don't see these warnings (and the like) in our apps that will have cypress testing:
image

image

To-Dos

  • Run tests (part of pre-push hook)
  • Update demo and tests, if linting configuration is being changed
  • Update documentation & README
  • Increment package.json version

…t include our extra rules that are not needed for that.

For example, we don't need to add test selectors for buttons in our cy tests.
@FSVetaz FSVetaz requested a review from a team as a code owner September 27, 2024 20:06
@FSVetaz FSVetaz changed the title Add cy files to our overrides for tests and non-production code to not include our extra rules that are not needed for that. Add cy files to our overrides for tests and non-production code to not include our extra rules that are not needed for that Sep 27, 2024
@FSVetaz FSVetaz requested a review from skye2k2 September 27, 2024 20:06
@FSVetaz FSVetaz marked this pull request as draft September 27, 2024 20:07
@FSVetaz FSVetaz removed the request for review from skye2k2 September 27, 2024 20:07
@FSVetaz FSVetaz marked this pull request as ready for review September 27, 2024 20:09
@FSVetaz FSVetaz requested a review from skye2k2 September 27, 2024 20:10
@FSVetaz FSVetaz merged commit 082391b into master Sep 30, 2024
1 check passed
@FSVetaz FSVetaz deleted the jordi/support-cy branch September 30, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants