Skip to content

Support the new @fs/zion/logical-over-directional #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .husky/pre-push
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
npm test
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ dist: focal
version: ~> 1.0
language: node_js
node_js:
- 16
- 20
branches:
only:
- master
Expand Down
82 changes: 78 additions & 4 deletions demo/test/snapshots/linting-config.test.js.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Generated by [AVA](https://ava.li).

`{␊
"env": {␊
"jest/globals": true,␊
"es2021": true,␊
"es6": true,␊
"node": true,␊
Expand Down Expand Up @@ -39,6 +40,8 @@ Generated by [AVA](https://ava.li).
"import",␊
"@babel",␊
"jsdoc",␊
"@fs/zion",␊
"jest",␊
"you-dont-need-lodash-underscore",␊
"prettier",␊
"test-selectors",␊
Expand All @@ -64,6 +67,12 @@ Generated by [AVA](https://ava.li).
"@babel/semi": [␊
"off"␊
],␊
"@fs/zion/logical-over-directional": [␊
"warn"␊
],␊
"@fs/zion/prefer-zion-render": [␊
"off"␊
],␊
"@typescript-eslint/block-spacing": [␊
"off"␊
],␊
Expand Down Expand Up @@ -496,7 +505,8 @@ Generated by [AVA](https://ava.li).
{␊
"maxDepth": "∞",␊
"ignoreExternal": false,␊
"allowUnsafeDynamicCyclicDependency": false␊
"allowUnsafeDynamicCyclicDependency": false,␊
"disableScc": false␊
}␊
],␊
"import/no-default-export": [␊
Expand Down Expand Up @@ -670,6 +680,63 @@ Generated by [AVA](https://ava.li).
"init-declarations": [␊
"off"␊
],␊
"jest/expect-expect": [␊
"warn"␊
],␊
"jest/no-alias-methods": [␊
"error"␊
],␊
"jest/no-commented-out-tests": [␊
"warn"␊
],␊
"jest/no-conditional-expect": [␊
"error"␊
],␊
"jest/no-deprecated-functions": [␊
"error"␊
],␊
"jest/no-disabled-tests": [␊
"warn"␊
],␊
"jest/no-done-callback": [␊
"error"␊
],␊
"jest/no-export": [␊
"error"␊
],␊
"jest/no-focused-tests": [␊
"error"␊
],␊
"jest/no-identical-title": [␊
"error"␊
],␊
"jest/no-interpolation-in-snapshots": [␊
"error"␊
],␊
"jest/no-jasmine-globals": [␊
"error"␊
],␊
"jest/no-mocks-import": [␊
"error"␊
],␊
"jest/no-standalone-expect": [␊
"error"␊
],␊
"jest/no-test-prefixes": [␊
"error"␊
],␊
"jest/valid-describe-callback": [␊
"error"␊
],␊
"jest/valid-expect": [␊
"error"␊
],␊
"jest/valid-expect-in-promise": [␊
"error"␊
],␊
"jest/valid-title": [␊
"error"␊
],␊
"jsdoc/check-alignment": [␊
"warn"␊
],␊
Expand Down Expand Up @@ -2317,7 +2384,7 @@ Generated by [AVA](https://ava.li).
{␊
"ignoreRefs": true,␊
"allowArrowFunctions": true,␊
"allowFunctions": false,␊
"allowFunctions": true,␊
"allowBind": false,␊
"ignoreDOMComponents": true␊
}␊
Expand Down Expand Up @@ -3185,6 +3252,9 @@ Generated by [AVA](https://ava.li).
"you-dont-need-lodash-underscore/chunk": [␊
"off"␊
],␊
"you-dont-need-lodash-underscore/clone-deep": [␊
2␊
],␊
"you-dont-need-lodash-underscore/collect": [␊
1␊
],␊
Expand Down Expand Up @@ -3424,7 +3494,9 @@ Generated by [AVA](https://ava.li).
".mts",␊
".tsx",␊
".js",␊
".jsx"␊
".jsx",␊
".mjs",␊
".cjs"␊
],␊
"import/external-module-folders": [␊
"node_modules",␊
Expand All @@ -3446,7 +3518,9 @@ Generated by [AVA](https://ava.li).
".mts",␊
".tsx",␊
".js",␊
".jsx"␊
".jsx",␊
".mjs",␊
".cjs"␊
]␊
}␊
},␊
Expand Down
Binary file modified demo/test/snapshots/linting-config.test.js.snap
Binary file not shown.
2 changes: 1 addition & 1 deletion es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ module.exports = {
'@fs/eslint-config-frontier-react/es6',
'@fs/eslint-config-frontier-react/json',
'@fs/eslint-config-frontier-react/jsdoc',
'@fs/eslint-config-frontier-react/jest',
'@fs/eslint-config-frontier-react/dont-need-lodash',
'@fs/eslint-config-frontier-react/typescript',
'@fs/eslint-config-frontier-react/prettierSetup', // Always have prettier last so it can override format rules in the extends before it
Expand Down Expand Up @@ -98,7 +99,6 @@ module.exports = {
overrides: [
{
files: ['*.stories.*', '*test*', '**/test/**', '**/*mock*/**', '*mock*', '**/setupTests.*', '**/fixtures/**'],
extends: ['@fs/eslint-config-frontier-react/jest'],
rules: {
'no-alert': 'off',
'no-console': 'off',
Expand Down
23 changes: 9 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@fs/eslint-config-tree",
"version": "6.0.1",
"version": "6.1.0",
"description": "Shared Tree configuration that contains overrides and enhancements on top of the base frontier configuration.",
"main": "index.js",
"repository": {
Expand Down Expand Up @@ -28,37 +28,32 @@
"!.*"
],
"dependencies": {
"@babel/eslint-parser": "^7.23.3",
"@fs/eslint-config-frontier-react": "^11.0.0",
"eslint": "^8.55.0",
"@babel/eslint-parser": "^7.25.1",
"@fs/eslint-config-frontier-react": "^11.2.0",
"eslint": "^8.57.1",
"eslint-plugin-bestpractices": "github:skye2k2/eslint-plugin-bestpractices",
"eslint-plugin-deprecate": "^0.7.0",
"eslint-plugin-html": "^7.1.0",
"eslint-plugin-promise": "^6.1.1",
"eslint-plugin-promise": "^6.6.0",
"eslint-plugin-sonarjs": "^0.22.0",
"eslint-plugin-test-selectors": "^2.1.1"
},
"devDependencies": {
"@fs/npm-publisher": "^1.5.2",
"@fs/npm-publisher": "^1.6.0",
"ava": "^2.4.0",
"file-manager-js": "^3.1.6",
"husky": "^3.1.0"
},
"husky": {
"hooks": {
"pre-push": "npm test"
}
"husky": "^9.1.6"
},
"scripts": {
"lint": "eslint demo",
"lint:fix": "eslint demo --fix",
"lint:quiet": "eslint demo --quiet",
"lint:report": "eslint demo '**/*.html' --format html --output-file ./reports/linting/linting_report.html & eslint demo --format json --output-file ./reports/linting/linting_report.json",
"lint:snapshot": "eslint --print-config file.js > ./demo/test/snapshots/local-linting-final-config.json; eslint demo --no-color --output-file ./demo/test/snapshots/local-linting-output.txt; npm run test:format",
"postinstall": "npm rebuild husky",
"publish": "npmPublish",
"test": "npm run lint:snapshot; ava",
"test:format": "node demo/test/snapshots/format-config.js",
"test:update": "npm run lint:snapshot; ava --update-snapshots"
"test:update": "npm run lint:snapshot; ava --update-snapshots",
"prepare": "husky"
}
}