Skip to content

UpdateQALintingRules #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2024
Merged

UpdateQALintingRules #19

merged 3 commits into from
Jan 31, 2024

Conversation

mamanakisdm
Copy link
Contributor

@mamanakisdm mamanakisdm commented Jan 30, 2024

QA uses WDIO, and with some of the ways WDIO is formatted, we use unnamed functions as our it functions.
We CAN use arrow functions, but that kills the ability to use this in our tests. Which we use a lot.

QA used WDIO and some of the ways WDIO is formatted, we use unnamed functions as our "it" functions (etc) ...
We CAN use arrow functions, but that kills the ability to use "this" in our tests. Which we use.
@mamanakisdm mamanakisdm requested a review from a team as a code owner January 30, 2024 17:06
@FSVetaz
Copy link
Contributor

FSVetaz commented Jan 30, 2024

The version needs to be updated.

Copy link
Contributor

@FSVetaz FSVetaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Probably good to get @skye2k2 to review and approve too.

@skye2k2 skye2k2 merged commit e126b72 into master Jan 31, 2024
@skye2k2 skye2k2 deleted the UpdateToQALintingRules branch January 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants