Shared linting for acceptance tests #16
Conversation
kylehar9
changed the title
kylehar9
changed the title
wdio.js
Outdated
| module.exports = { | ||
| overrides: [ | ||
| { | ||
| files: ['test/client/**/*.js'], |
There was a problem hiding this comment.
Would just test/**/*.js work?
index.js
Outdated
| @@ -1,3 +1,3 @@ | |||
| module.exports = { | |||
| extends: ['@fs/eslint-config-frontier-react/react', './es6'], | |||
| extends: ['@fs/eslint-config-frontier-react/react', './es6', './wdio'], | |||
There was a problem hiding this comment.
I know this is mostly arguing semantics, but I would rather have this called something more like qa, since there is no reason to be specific to the current technology being used.
| @@ -88,9 +88,6 @@ Generated by [AVA](https://ava.li). | |||
| "@typescript-eslint/keyword-spacing": [␊ | |||
| "off"␊ | |||
| ],␊ | |||
| "@typescript-eslint/lines-around-comment": [␊ | |||
There was a problem hiding this comment.
@FSVetaz: I understand running this command, but I am extremely confused as to why this change does not show anywhere in the resulting files changed.
There was a problem hiding this comment.
Something on Kyle's machine is weird and it added this. It shouldn't be added in theory--it's a formatting rule. Not sure why Kyle's machine added it.
I didn't delve to deep into why that was.
There was a problem hiding this comment.
With or without it, nothing changes in the resulting eslint linting/formatting
Description
Add shared configuration for our WDIO acceptance tests.
Add fixtures to the test overrides list where certain rules are disabled.
Changes
qa.jsconfiguration added.6.0.0-alpha.4.