Remove preinstall to see if that is causing issues with prerender-service #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FSVetaz
force-pushed
the
jordi/preinstall
branch
from
d23c878 to
8819319
Compare
FSVetaz
commented
Mar 20, 2023
skye2k2
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Good job catching the ordering issue that we never saw locally because the files already existed from us running npm test previously.
I really would rather have a searchable text entry than a screenshot for the error we are attempting to resolve in the body of the commit, but this looks worth trying.
|
Meaning that you merging the pull request without modifying the commit message has me irritated. |
Oh! Sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update @fs/eslint-config-frontier-react too, see fs-webdev/eslint-config-frontier-react#38
This is the issue in prerender-service, so seeing if this will fix this.
npm ERR! code 255
npm ERR! path /var/app/staging/node_modules/eslint-config-tree
npm ERR! command failed
npm ERR! command sh -c -- git config --global url.https://github.com/.insteadOf git://github.com/
npm ERR! warning: unable to access '/root/.gitconfig': Permission denied
npm ERR! warning: unable to access '/root/.config/git/config': Permission denied
npm ERR! error: could not lock config file /root/.gitconfig: Permission denied