add .travis.yml and @fs/npm-publisher #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FSVetaz
reviewed
Mar 17, 2023
.travis.yml
Outdated
| before_install: | ||
| - echo "//familysearch.jfrog.io/artifactory/api/npm/fs-npm-prod-virtual/:_authToken=${NPM_PUBLISH_TOKEN}" >> ~/.npmrc | ||
| - echo "@fs:registry=https://familysearch.jfrog.io/artifactory/api/npm/fs-npm-prod-virtual/" >> ~/.npmrc | ||
| script: npm run lint && npm run test |
There was a problem hiding this comment.
Suggested change
| script: npm run lint && npm run test | |
| script: npm run test |
There was a problem hiding this comment.
This will still fail, since rules have changed in the last two weeks.
TODO: Review the rule changes, and cut a new release.
Give it something else to run.
skye2k2
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a .travis.yml file, and adding the publishing helper @fs/npm-publisher to devDependencies
I've already added the npm publish token envVar to travis.