Skip to content

Change cognitive-complexity back to 25 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

FSVetaz
Copy link
Contributor

@FSVetaz FSVetaz commented Mar 8, 2023

50 is a bit too high and we used to have it at 25. We had it for 50 for test/stories/mock files in babylon. But we now have it off for those files.

To-Dos

  • Run tests (part of pre-push hook)
  • Update demo and tests, if linting configuration is being changed
  • Update documentation & README
  • Increment package.json version

@FSVetaz FSVetaz requested a review from a team as a code owner March 8, 2023 21:12
Copy link
Collaborator

@skye2k2 skye2k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this then add a 50 complexity entry to the test files override section, instead of having it off? I think it is valuable to not have your test files be too obtuse.

@FSVetaz
Copy link
Contributor Author

FSVetaz commented Mar 8, 2023

Shouldn't this then add a 50 complexity entry to the test files override section, instead of having it off? I think it is valuable to not have your test files be too obtuse.

That's fine

@FSVetaz FSVetaz merged commit a7611d3 into master Mar 8, 2023
@FSVetaz FSVetaz deleted the jordi/cog-complex branch March 8, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants