Skip to content

v6 alpha #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
Mar 6, 2023
Merged

v6 alpha #11

merged 54 commits into from
Mar 6, 2023

Conversation

FSVetaz
Copy link
Contributor

@FSVetaz FSVetaz commented Feb 23, 2023

Major release: v6-alpha

Consume latest eslint-config-frontier-react.
Remove all Polymer-based, Code Climate-related, and legacy configuration and documentation.
Upgrade eslint version.
Update snapshots to take all new rules into account.
Centralize all of our typical overrides (.ts, .stories, .test, etc.), and compartmentalize into its own es6.js file.

This 2 space is temp for this pr
@babel/eslint-parser is the successor of babel-eslint for parsing. I just copied what is in @fs/eslint-config-frontier-react/es6 for the parserOptions for now.

added es2021 env like frontier does.

removed all globals. We won't need these in react apps.

Add all plugins in deps. node is not actually used but I just added it in for now.

Added default-case and valid-jsdoc back in

removed jsdoc/check-examples; eslint-8 does not support it.

removed array-bracket-spacing, no-extra-semi, object-curly-newline, and semi as they will conflict with prettier as seen with npx eslint-config-prettier file.js after extending it. (I un-extended it for this commit to not have too many differences; I will add @fs/eslint-config-frontier-react/prettier in a later commit)

move demo rule overrides to demo directory; only extend index.js for the normal .eslintrc.js file

Put return-early-return in a function so that we have that logged and still have eslint work correctly for the file.

make repo use npm 8 via node 16 and save updated package versions when npm update
jest version is only needed to be explicitly declared here because we don't use jest in this repo
Differences:
eslint won't complain on json files if there is a comment (good so we don't get eslint failing on a json file that actually does allow comments like some do (eslintrc.json is an example))
it still says what the issue is, but it doesn't specify the exact json rule because they are all combined into json/*

I think this is fine.
…them

Added comments about the differences tht frontier/tw-blue does

all other rules were not in frontier.

Nothing changed in final config. (only the ordering of env because we don't sort that)
No difference for a js file
@FSVetaz FSVetaz force-pushed the jordi/compare-final-config branch from 8694b78 to e9220ec Compare February 23, 2023 17:11
@skye2k2 skye2k2 changed the title Jordi/v6 alpha v6 alpha Feb 24, 2023
@FSVetaz
Copy link
Contributor Author

FSVetaz commented Feb 24, 2023

This is what our repositories look like with the rules and with me making some updates. image

we need to talk about some of these rule I updated, and also the reasoning behind some of the overrides between us and frontier and if we still want to override those rules. We could have a meeting on it on Monday.

@FSVetaz FSVetaz marked this pull request as ready for review February 24, 2023 18:42
@FSVetaz FSVetaz requested a review from a team as a code owner February 24, 2023 18:42
@skye2k2
Copy link
Collaborator

skye2k2 commented Feb 24, 2023

Let's plan on talking in between meetings on Monday. I hope you kept track somewhere central all of the rules we need to go over. I will re-add/change bits that I see didn't fully sync. Initially, running these changes locally resulted in a loss all the errors and warnings from example.js, and my in-IDE linting no longer ran against any of the example files. I will reset and re-install, and see if things start working.

@skye2k2 skye2k2 merged commit 1a9616a into master Mar 6, 2023
@skye2k2 skye2k2 deleted the jordi/v6-alpha branch March 6, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants