Skip to content

Compare Final Config for Testing #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 24, 2023
Merged

Conversation

FSVetaz
Copy link
Contributor

@FSVetaz FSVetaz commented Feb 22, 2023

Print out final eslint config with the rules sorted alphabetically. Then it will be compared to the previous reason.

To-Dos

  • Run tests (part of pre-push hook)
  • Update demo and tests, if linting configuration is being changed
  • Update documentation & README
  • Increment package.json version

@FSVetaz FSVetaz requested a review from a team as a code owner February 22, 2023 23:07
@FSVetaz FSVetaz changed the title Compare Final Config for Ttesting Compare Final Config for Testing Feb 23, 2023
Base automatically changed from jordi/test-upd to master February 23, 2023 15:57
@skye2k2
Copy link
Collaborator

skye2k2 commented Feb 23, 2023

The purpose of having the output saved in a readable (multiline) format is so that the humans can see what changed. Shoving everything into one line might make the test output cleaner, but makes the git diff a nightmare.

@FSVetaz FSVetaz force-pushed the jordi/compare-final-config branch from 8694b78 to e9220ec Compare February 23, 2023 17:11
@skye2k2
Copy link
Collaborator

skye2k2 commented Feb 23, 2023

npm test now creates an untracked demo/test/snapshots/new-lint-results.txt-e file with the original content.

Tests almost pass, but new-lint-final-config.json has a developer-specific entry:

"parser": "/home/vetaz/fs-webdev/eslint-config-tree/node_modules/babel-eslint/lib/index.js"

@skye2k2
Copy link
Collaborator

skye2k2 commented Feb 23, 2023

I did not like the -e extension added to the output file. Can you test to see if using a .tmp extension breaks in your version of sed?

@FSVetaz
Copy link
Contributor Author

FSVetaz commented Feb 23, 2023

I did not like the -e extension added to the output file. Can you test to see if using a .tmp extension breaks in your version of sed?

That doesn't work unfortunately.
image

@skye2k2
Copy link
Collaborator

skye2k2 commented Feb 23, 2023

And if it is quoted '.tmp'?

@FSVetaz
Copy link
Contributor Author

FSVetaz commented Feb 23, 2023

And if it is quoted '.tmp'?

nope. You use FreeBSD? instead of OS X's sed?

FSVetaz and others added 3 commits February 23, 2023 19:36
Make formatter script compatible with node < 16.
Re-remove unnecessary `hi` addition.
Running on OSX after Jordi's change to format linting results in his node script resulted in whitespace changes. Likely will need addressed.
@@ -12,6 +12,10 @@
// Hack: Note that these work, regardless of case
// Here be Dragons

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh that is interesting

Copy link
Collaborator

@skye2k2 skye2k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your diligent work on this. I feel much more secure in making new changes, now.

@skye2k2 skye2k2 merged commit 67f22ae into master Feb 24, 2023
@skye2k2 skye2k2 deleted the jordi/compare-final-config branch February 24, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants