Add protobuf definitions for reporting API v2 #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:proto
Signed-off-by: Stefan Brus <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Adds a new protobuf definitions file intended for reporting API v2 and updates the existing v1 definitions to use the newer common v1 package paths. Key changes:
- Introduces a v2 reporting.proto file (currently declares the package as v1, likely unintended).
- Updates v1 reporting.proto imports and type references from v1alpha8 to v1 common packages.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| proto/frequenz/api/reporting/v2/reporting.proto | Adds new (intended v2) reporting API definitions; contains several documentation and package declaration issues. |
| proto/frequenz/api/reporting/v1/reporting.proto | Updates imports and type names to newer common v1 package resources. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
stefan-brus-frequenz
force-pushed
the
apiv2
branch
3 times, most recently
from
953c9a8 to
e48e0c9
Compare
Signed-off-by: Stefan Brus <[email protected]>
stefan-brus-frequenz
force-pushed
the
apiv2
branch
from
e48e0c9 to
6874143
Compare
Signed-off-by: Stefan Brus <[email protected]>
stefan-brus-frequenz
force-pushed
the
apiv2
branch
from
284c573 to
c3586f0
Compare
tiyash-basu-frequenz
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes done to
reporting.protoin 638fa11Instead, the v1alpha8 common API messages are introduced in a separate protobuf definitions file, under the package path
frequenz.api.reporting.v2.