sync with superagent bug fixes #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following superagent:
PR: forwardemail/superagent#1556
commit: forwardemail/superagent@4babc5d
…t more than `ca`, `key`, `cert` `options` object is now a direct passthrough, TestAgent can support whichever superagent's Agent is expecting i.e. `ca`, `key`, `cert`, `pfx`, `rejectUnauthorized`
`Test` constructor has already removed the host param in de056d2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
as
supertestoverrides some of thesuperagentimplementations, it is important that fixes have to be ported overfeat
TestAgentand superagent'sAgentoptionsobject is now a direct passthrough (no more hard-coding ofca,key,cert)refactor
TestobjectTestconstructor has already removed thehostparam in de056d2