Skip to content

Fix outdated info in README.md #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Nov 15, 2024

  • Replace the old Travis CI badge with GitHub Action's one.
  • Correct the path to SGX code in README.

@Taowyoo Taowyoo self-assigned this Nov 15, 2024
@Taowyoo Taowyoo enabled auto-merge November 15, 2024 19:48
@Taowyoo Taowyoo linked an issue Nov 15, 2024 that may be closed by this pull request
@Taowyoo Taowyoo force-pushed the 656-bug-readme-link-is-dead branch from 4ff6cd7 to deae9d6 Compare January 13, 2025 21:53
@Taowyoo Taowyoo force-pushed the 656-bug-readme-link-is-dead branch 2 times, most recently from e0b0b97 to 58cbca3 Compare February 26, 2025 17:41
@Taowyoo Taowyoo force-pushed the 656-bug-readme-link-is-dead branch from 58cbca3 to a923292 Compare March 25, 2025 19:20
@Taowyoo Taowyoo requested a review from nshyrei March 25, 2025 19:21
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Mar 25, 2025

Hi @nshyrei could you help re-approve this PR.
I update CI to not ignore changes on docs.
This is a simple fix for now because To make CI and status check to work correctly with path ignore is complex.

@Taowyoo Taowyoo changed the title fix outdated info in README.md Fix outdated info in README.md Mar 25, 2025
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented May 6, 2025

Hi @raoulstrackx @aditijannu could you help review and approve this PR? Thanks

@@ -2,9 +2,6 @@ name: CI

on:
pull_request:
paths-ignore:
- '*.md'
- 'LICENSE'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link
Collaborator Author

@Taowyoo Taowyoo Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, no CI will run then it breaks the check requirement on the PR.
It's complex to setup a conditional check requirement on this.

@Taowyoo Taowyoo requested a review from raoulstrackx June 17, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: readme link is dead
3 participants