core2: refactor playground III #244
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added rust-releases-core2 which will eventually replace rust-releases-core. This library contains the primary "Release" structs while everything "toolchain" related will be moved to the rust-toolchain crate. The second added crate is rust-releases-compact-index; for this crate the intention is to create a compact version from AWS index which is too large to be pulled from quickly.
* version field was pub(crate) * Also removed outdated comment
Allows users to differentiate by platform, or use the 'global' registry.
Work towards allowing registers by something else than the platform, e.g. StableRegister or a register which consists of {StableRegister, BetaRegister, NightlyRegister}.
Possibly make "Register" itself a trait and rename the current struct to "PlatformRegister".
* Defining ordering with the previous definition was not pretty; you could reason in multiple ways about the multi field comparison. * A release has a release date, not toolchain. The toolchain is reduced to its channel and platform. * Channel is reworked: it is no longer an identifier only; instead, stable and beta channels have a version, and nightly has a date; this matches up with the "versions" used by the Rust project. * Release now consists of a release date, a toolchain and one or more components.
This constructor function defaults to the triple unknown-unknown-unknown if the given target triple is not recognized, unlike try_from_target_triple, which errors if the given triple is not recognized.
Attempt to clarify the difference in meaning (for this library) between the generic term "Rust release", which may be a: toolchain release, a language version release, a distribution release.
foresterre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.