@W-20173671: [Android] Extra session on logout/add account when upgrading from Mobile SDK 12 to 13 #2806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -821,9 +816,6 @@ | |||
Contributor
Author
There was a problem hiding this comment.
Note this private method is only called from one location, which now has the remove all cookies statement.
| */ | ||
| private fun notifyLogoutComplete(showLoginPage: Boolean, logoutReason: LogoutReason, userAccount: UserAccount?) { | ||
| // Clear cookies to ensure those used during previous log in will not be re-used to log the user in again. | ||
| CookieManager.getInstance().removeAllCookies(null) |
Contributor
Author
There was a problem hiding this comment.
Now the remove all cookies call is outside of the show login page parameter's influence.
…ding from Mobile SDK 12 to 13
JohnsonEricAtSalesforce
force-pushed
the
bugfix/w-20173671_android-extra-session-on-logout_add-account-when-upgrading-from-mobile-sdk-12-to-13
branch
from
4a936dd to
3c77365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎸 Ready For Review 🥁
This corrects log out to always clear cookies from the web view to prevent them being used to sign a user in again. This prevents a case where a user who had recently logged in via MSDK 12 would still have those cookies plus the app passes false to the log out method after the app updates to MSDK 13, which would prevent the log out methods from clearing the cookies. It's an edge case, perhaps, but one we have seen in the field.