[device_info_plus] Added more information for Windows

[alexmercerind]

Description

Now device_info_plus fetches a lot more information on Windows compared to before.
This has many use-cases like identifying Windows version, getting username, install date, build number or product ID (for software license handling) etc.

Reference Images

[sensitive data is hidden]

Windows 10

Windows 11

{
  'computerName': computerName,
  'numberOfCores': numberOfCores,
  'systemMemoryInMegabytes': systemMemoryInMegabytes,
  'userName': userName,
  'majorVersion': majorVersion,
  'minorVersion': minorVersion,
  'buildNumber': buildNumber,
  'platformId': platformId,
  'csdVersion': csdVersion,
  'servicePackMajor': servicePackMajor,
  'servicePackMinor': servicePackMinor,
  'suitMask': suitMask,
  'productType': productType,
  'reserved': reserved,
  'buildLab': buildLab,
  'buildLabEx': buildLabEx,
  'digitalProductId': digitalProductId,
  'displayVersion': displayVersion,
  'editionId': editionId,
  'installDate': installDate,
  'productId': productId,
  'productName': productName,
  'registeredOwner': registeredOwner,
  'releaseId': releaseId,
  'deviceId': deviceId,
}

Related Issues

Closes #177

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated the version in pubspec.yaml and CHANGELOG.md.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[alexmercerind]

cc @mhadaily.

Thanks a lot!

[miquelbeltran]

Very cool, thanks! I will test this before approving and merging when I got time.

Meanwhile, is there any way you could add a test or two? so then codecov won't complain.

[alexmercerind]

Thanks for the follow up @miquelbeltran!

I improved the tests for Windows, but it seems we're currently using ubuntu-latest (even on Windows). And DLLs required for the native calls cannot be located on Linux (or am I missing something?).

EDIT: Other plugins don't seem to have tests for *_windows packages.

plus_plugins/.github/workflows/device_info_plus.yaml

Lines 68 to 79 in 08a7a35

	windows:
	runs-on: ubuntu-latest
	timeout-minutes: 30
	steps:
	- name: "Checkout repository"
	uses: actions/checkout@v2
	- name: "Install Flutter"
	run: ./.github/workflows/scripts/install-flutter.sh stable
	- name: "Install Tools"
	run: ./.github/workflows/scripts/install-tools.sh
	- name: "Build Example"
	run: ./.github/workflows/scripts/build-examples.sh windows ./lib/main.dart

Any solution that seems good to you?
Thanks.

[miquelbeltran]

Hi @alexmercerind

I saw that the test_and_coverage job is failing in the device_info_plus_windows project. Can you take a look?

I haven't looked into it, but I guess you need to have a way to mock the calls to the missing dll in the tests

[Fraa-124]

Please merge this! this is a must for managing devices!!

[jaxnz]

Please merge this! this is a must for managing devices!!

Agreed - what do we need to do to get this over the line?

[miquelbeltran]

I resolved the merge conflicts, once CI finishes I will merge and release.

[miquelbeltran]

merged and published

[miquelbeltran]

This PR had to be reverted because the changes were not put in a major version, a new PR will come with the changes reapplied.