Skip to content

Conversation

@aakash-pamnani
Copy link
Contributor

@aakash-pamnani aakash-pamnani commented Mar 29, 2022

Description

setPerioidic was not working due to parameter sequence was not correct.

and if less than 60 sec interval given android will make it default to 60 sec
this is what i got from log
image

Related Issues

#787
#709

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@aakash-pamnani
Copy link
Contributor Author

aakash-pamnani commented Apr 1, 2022

I am a beginner and learning , please let me know if anything is wrong.

@aakash-pamnani aakash-pamnani changed the title Solved AndroidAlarmManager.periodic() not working. [android_alarm_manager_plus] Solved AndroidAlarmManager.periodic() not working. Apr 1, 2022
@aakash-pamnani aakash-pamnani changed the title [android_alarm_manager_plus] Solved AndroidAlarmManager.periodic() not working. Fix [android_alarm_manager_plus] AndroidAlarmManager.periodic() not working. Apr 5, 2022
@vbuberen vbuberen self-assigned this Apr 11, 2022
@Andrew-Bekhiet
Copy link
Contributor

Any update on this?

@Andrew-Bekhiet
Copy link
Contributor

I don't understand why no one has approved this simple yet critical fix

@aakash-pamnani
Copy link
Contributor Author

aakash-pamnani commented Jun 15, 2022

I don't understand why no one has approved this simple yet critical fix

Yes ,its been more than 2 months now still no response from reviewer.

@vbuberen
Copy link
Collaborator

vbuberen commented Jun 15, 2022

I don't understand why no one has approved this simple yet critical fix

Because Plus Plugins is an open source project, which people maintain in their free time for free. It is not a commercial product where somebody charges some licences fees, etc. to complain this way.

It will be reviewed when it will be reviewed. If it is something that critical for you it would be better to test the fix and provide feedback if it really changes something in the meantime instead of just writing Any update on this. This way it would be more constructive way on helping to move forward.

@Andrew-Bekhiet
Copy link
Contributor

Because Plus Plugins is an open source project, which people maintain in their free time for free. It is not a commercial product where somebody charges some licences fees, etc. to complain this way.

I'm sorry if I seemed a little aggressive on this

If it is something that critical for you it would be better to test the fix and provide feedback

I've tested it since I've seen it for the first time, and it fixes this bug that has bothered me for about a month before I saw the pr

@vbuberen
Copy link
Collaborator

I've tested it since I've seen it for the first time, and it fixes this bug that has bothered me for about a month before I saw the pr

Thanks for your feedback. I will try to get to this PR this week and test/review as well.

Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the change and it looks like it is really a fix, since there was a typo with wrong order of parameters. Also did some testing on a few emulators and real devices with different Android versions and can confirm that this change fixes the periodic alarm.

Thanks for your contribution.

Might also be a fix for #901 and #871

Closes #787 and #709

@miquelbeltran
Copy link
Member

release 2.0.6 published, thanks everyone for getting into this!

@carman247
Copy link

carman247 commented Jun 23, 2022

Still doesn't work ...

Better to use a oneShot that then triggers another oneShot after a delay when the first one fires.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants