-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix [android_alarm_manager_plus] AndroidAlarmManager.periodic() not working. #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am a beginner and learning , please let me know if anything is wrong. |
|
Any update on this? |
|
I don't understand why no one has approved this simple yet critical fix |
Yes ,its been more than 2 months now still no response from reviewer. |
Because Plus Plugins is an open source project, which people maintain in their free time for free. It is not a commercial product where somebody charges some licences fees, etc. to complain this way. It will be reviewed when it will be reviewed. If it is something that critical for you it would be better to test the fix and provide feedback if it really changes something in the meantime instead of just writing |
I'm sorry if I seemed a little aggressive on this
I've tested it since I've seen it for the first time, and it fixes this bug that has bothered me for about a month before I saw the pr |
Thanks for your feedback. I will try to get to this PR this week and test/review as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the change and it looks like it is really a fix, since there was a typo with wrong order of parameters. Also did some testing on a few emulators and real devices with different Android versions and can confirm that this change fixes the periodic alarm.
Thanks for your contribution.
|
release 2.0.6 published, thanks everyone for getting into this! |
|
Still doesn't work ... Better to use a |
Description
setPerioidic was not working due to parameter sequence was not correct.
and if less than 60 sec interval given android will make it default to 60 sec

this is what i got from log
Related Issues
#787
#709
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
pubspec.yamlandCHANGELOG.md.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?